Clean up error handling in hwilib #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK Can you also do this in cli.py? |
jb55
force-pushed
the
handle-errors-util
branch
4 times, most recently
from
a7c3db7
to
8fdd5e0
Compare
|
I'm not sure if these are covered by tests, I'm doing these refactors without a way of testing them. |
jb55
force-pushed
the
handle-errors-util
branch
2 times, most recently
from
0865f9b
to
a81d051
Compare
@achow101 done |
achow101
reviewed
Jun 18, 2019
jb55
commented
Jun 18, 2019
This can be used in with blocks to abstract our error handling Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin
|
ACK f430e25 |
achow101
added a commit
that referenced
this pull request
Jun 18, 2019
f430e25 cli: use handle_errors (William Casarin) 5d1c2bb ledger: use handle_errors in enumerate (William Casarin) 53104be digitalbitbox: use handle_errors in enumerate (William Casarin) 42fbeaa trezor: use handle_errors in enumerate (William Casarin) b6ca7d9 coldcard: use handle_errors in enumerate (William Casarin) 313e012 keepkey: use handle_errors in enumerate (William Casarin) c75b5e2 errors: add handle_errors helper (William Casarin) Pull request description: ACKs for commit f430e2: achow101: ACK f430e25 Tree-SHA512: 751584a4db1b1321909804c388bd4475901ddeacddb9750d19140ca60f824c806f8fdacdee2d8a57c7f4549cda99871e3f16988b678ea216a5e701c15d7f7db3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.