Add --signet as alias for --testnet #451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might have been cleaner to introduce another flag and then use |
|
At this rate, we should just do |
|
That works for me, but is probably above my paygrade :-) I assume you want to keep |
2 tasks
|
I created an alternative PR which implements |
achow101
added a commit
that referenced
this pull request
Feb 10, 2021
…net) a7d14ba Remove client.is_testnet usage in getdescriptor (Pavol Rusnak) be2f95a Introduce --chain command line argument (replacing --testnet) (Pavol Rusnak) Pull request description: Alternative to #451 This nukes `--testnet` argument. If we want to keep that, I'll reintroduce it in another commit. Just let me know. I just think it's fine to get rid of that now, since we are breaking the API anyway in HWI 2.0. Also we should get rid of `client.is_testnet` across the whole codebase and check against the `client.chain`, but I'd prefer to leave that for later PR. ACKs for top commit: achow101: ACK a7d14ba Tree-SHA512: f2827399a9685d1826dc60bcda8582f03243608049e41dfb48887fcca47208b0f3d16d93eb4876ac222eab17623c09ba8a0dbd4ac3d47d8254f7a99955b62d4f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to modify bitcoin/bitcoin#16546 to use
--signet.