Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add looping animation to Estimating state #325

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

jarolrod
Copy link
Member

@jarolrod jarolrod commented Apr 19, 2023

Implements the following design: BitcoinDesign/Bitcoin-Core-App#48

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

@jarolrod jarolrod added UX Designers' opinions are required Needs design review Designer's review needed labels Apr 19, 2023
@GBKS
Copy link
Contributor

GBKS commented Apr 21, 2023

Looking good, I think it helps, although it feels just a tad too strong, especially when you also have the peer dots blinking. Could we try animating between Neutral 4 and Neutral 6, please?

It also feels like this animates with a very slow frame rate, like it's lagging a bit (on a very fast MacBook). Do you see the same?

@jarolrod
Copy link
Member Author

Updated from a41be94 to c95771e, compare

Changes: addressed review feedback

@GBKS I don't notice any animation issues

@jarolrod
Copy link
Member Author

updated from c95771e to 1271377

changes: rebased over main

@jarolrod jarolrod added this to the v1.1 milestone Jun 6, 2023
Copy link
Contributor

@D33r-Gee D33r-Gee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

Built android apk (armv7a) using WSL Ubuntu 22.04.

Looks great on device (Galaxy A13 5G), the “Estimating” text cycles through the color animation as expected.

@GBKS
Copy link
Contributor

GBKS commented Jul 6, 2023

ACK 1271377

@hebasto hebasto merged commit 175f5a9 into bitcoin-core:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs design review Designer's review needed UX Designers' opinions are required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants