Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtle animation on "Estimating" state #48

Closed
GBKS opened this issue Apr 17, 2023 · 2 comments
Closed

Subtle animation on "Estimating" state #48

GBKS opened this issue Apr 17, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@GBKS
Copy link
Contributor

GBKS commented Apr 17, 2023

This block clock state can feel like it's unresponsive because you might see it for minutes and there's no motion at all.

Frame 156

If the text "Estimating" subtly changes color (like from neutral 7 to neutral 5 and back), it might feel a bit more like something is actually happening. This could also work well for the "0%" text. If we're not even at "0.01%", a subtle animation (neutral 9 to 7) would help communicate that something is happening.

What do you think?
@GBKS GBKS added the enhancement New feature or request label Apr 17, 2023
@jarolrod jarolrod mentioned this issue Apr 19, 2023
Merged
@jarolrod
Copy link
Collaborator

Addressed by bitcoin-core/gui-qml#325

hebasto added a commit to bitcoin-core/gui-qml that referenced this issue Jul 12, 2023
@hebasto
Merge #325: Add looping animation to Estimating state
175f5a9 
1271377 qml: add looping animation to Estimating state (Jarol Rodriguez)

Pull request description:

  Implements the following design: BitcoinDesign/Bitcoin-Core-App#48

  [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/325)
  [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/325)
  [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/325)
  [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/325)

ACKs for top commit:
  GBKS:
    ACK 1271377

Tree-SHA512: 50ba69aa33a654db7bc4b0d6cf50c6a264c2daef43fc8a7a74c1a2a2ab27fa3de43920e44e5d692ea1ebcc785844d723f20eb7b573ff1cfb57743687e63e472d
@jarolrod
Copy link
Collaborator

Closing as this was done already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GBKS @jarolrod