-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fork-observer: reduce query interval #175
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lgtm I might want to add some randomness to the query interval for each node in fork-observer so you don't end up firing 200 RPC calls exactly ever 60s. |
Also, keep in mind that fork-observer currently has a limit of 256 nodes per network. It's trivial to increase it but I haven't gotten to it yet. 0xB10C/fork-observer#22 |
Oh right, I think I will also add a commit here to disable if the graph is >256 nodes then |
I've fixed it in fork-observer: 0xB10C/fork-observer#24 The new docker image should allow Warnet to theoretically attach more than 256 nodes. Not sure if that's practical though. |
Do we still need this now that fork observer was updated? There's also #177 |
Yeah we want this. Updated FO lets us attach more nodes (256 limit), this queries the nodes less frequently. You know how you saw FO was using the most CPU/bandwidth on the graphs earlier... ;) #177 is different |
Would be even nicer (for us) if FO would query on a chill scheduler, e.g. If you configure 100 nodes and query every 60 seconds it could query one node every 0.6 seconds to keep resource usage as flat as possible. Vs currently where every n seconds it will query all nodes at the same time (or as fast as it can). But I haven't thought about side effects of that for wider FO usage and that's a PR for another repo in any case! |
can remove this commit though? bf2e058 |
ohhhhh, sure |
For S-C-A-L-I-N-G
bf2e058
to
686397c
Compare
rebased and dropped commit |
Agree, I made an issue for this 0xB10C/fork-observer#23 the other day. |
For S-C-A-L-I-N-G
Reduce query interval to every 60 seconds by default. Helps on larger networks.