fork-observer: extract from warnet #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is best implemented by the container implementation
Helps highlight why fork_observer_config function is not called from in here
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Concept ACK If I'm understanding the description, this means each backend needs to decided how/if to implement fork observer? |
|
Yeah that's right. I think we should really get it back, as it's a great tool, but maybe low prio until after we get some tests running stably on k8s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is best implemented by the container implementation
@josibake Going to propose this for now. We should remove FO from
Warnetin any case, this just lets you handle it in your own way more cleanly