-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new BIP: codex32 #1425
new BIP: codex32 #1425
Conversation
Add a comment that notes that if you are resharing a secret by taking existing shares an recovering the secret, tossing out the old shares and making new ones, it is important to create a fresh unique ID. Without a fresh ID you run the risk of accidentally combining old shares with new shares (due to forgetting to destroy some old shares), which could lead to confusion and/or the apparent loss of funds. |
After discussion with Christopher Allen et. al., I've opened PR apoelstra#2 for adding a rationale section for not encoding BIP-0039 entropy. I suppose comments on that proposed amendment should be directed to that PR, while this PR remains open for assigning a BIP number and other comments on this proposal. |
Recommend noting master xprvs in each test case. |
bip-0000.mediawiki
Outdated
<pre> | ||
BIP: ???? | ||
Layer: Applications | ||
Title: codex32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer a title that means something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Maybe something like Codex32 format for Shamir Secret Shares of [BIP-0032] master seeds
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. How about "codex32: a bech32-based BIP32 seed encoding supporting Shamir Secret Sharing and hand computation"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed.
6ce70ec
to
f40cadd
Compare
It'd be nice to get SLIP39 BIPed as well as this at some point in the future (especially as this draft BIP references it) if that factors into the BIP number allocation and possible number grouping(s). |
NACK - Not in keeping with the Bitcoin Philosophy |
I stumbled across a memo from 93 BC that appears to say this has been assigned BIP number 93. |
641b157
to
5bbf0db
Compare
Thanks @luke-jr! I have squashed all the existing commits and added a new one which sets the number (and sets the type to "Informational", which matches my intuition about this and also matches BIP 173, which is similar in spirit). We are not quite ready to merge -- we have a new reference implementation we want to link to (with Postscript and Rust, for now) and |
Using the identifier "faux" for invalid test vectors. Extending the set of example a little bit.
f37d0a7
to
b6821a4
Compare
Just a reminder to add the BIP entry to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kallewoof I think we are ready to merge this |
This introduces "codex32", a wallet seed/share format that uses the bech32 alphabet, a bech32-like checksum, and supports Shamir Secret Sharing, all possible without the use of electronic computers (although you can, and for some steps probably should, use computers if you want).
Mailing list discussion: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2023-February/021469.html
Website with more docs about hand computation (which isn't really covered by the BIP): https://secretcodex32.com/index.html