Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIP 39] Add reference implementation #1095

Merged
merged 2 commits into from
Jun 13, 2021
Merged

Conversation

eMaringolo
Copy link
Contributor

Add an existing reference implementation done in 100% Smalltalk code.

@luke-jr
Copy link
Member

luke-jr commented Apr 22, 2021

bip-0039.mediawiki Outdated Show resolved Hide resolved
@luke-jr luke-jr changed the title Add reference implementation [BIP 39] Add reference implementation Apr 25, 2021
@eMaringolo
Copy link
Contributor Author

Is there anything stopping this minor change from being merged?

@prusnak
Copy link
Contributor

prusnak commented May 27, 2021

@eMaringolo I posted a suggestion above how you should fix a syntax error. Once this has been addressed I don't see any further issues.

Fixes syntax error.

Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
@prusnak
Copy link
Contributor

prusnak commented May 28, 2021

ACK

1 similar comment
@garkelin
Copy link

ACK

@maflcko
Copy link
Member

maflcko commented May 31, 2021

@luke-jr

@kallewoof kallewoof merged commit 36a0855 into bitcoin:master Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants