Remove newline to fix list rendering #1157
Merged
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the newline in list items is causing the text on the new line to be rendered as a code section. I am unsure why but I'm guessing putting all the text for each list item on a single line will fix it.
|
Verified that the display issue exists and that the patch fixes rendering. I tested removing the whitespace after the newline but preserving the newline itself to see if that helped but it did not, so the suggested solution seems reasonable to me. Minor nit if you're up for ACKing, @Roasbeef and/or @aakselrod |
Lcote71
approved these changes
Sep 1, 2021
|
Friendly bump - I went to read the BIP again today, saw the issue, went to fix it, and realized I fixed it years ago :) |
|
This looks good to me. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the newline in list items in BIP-0158 is causing the text on the new line to be rendered as a code section. I am unsure why this is happening but putting all the text for each list item on a single line fixes it.