New BIP: P2P Feature Negotiation #1377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK. It's good to standardize this direction forward. Service bits are better used for stuff considered at peer selection (e.g., spv servers). One might argue peers may want to find Erlay or WTXID peers too, but I think that usually opens up risks, so this should be done only when absolutely necessary (e.g., spv servers). The problem with version bits is the ordering i guess, which makes sense to be linear ("version"), rather than an un-ordered bitmask value. |
manda2020panda
approved these changes
Dec 11, 2022
|
What was the ML thread discussing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.