BIP 144: Segregated Witness (Peer Services) #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like "spellcheck as you type" was enabled when creating the diagram giving the squiggly red lines. |
| === Handshake === | ||
| A new message 'havewitness' is sent after receiving 'verack' to | ||
| indicate that a node can provide witness if requested (similar to | ||
| 'sendheaders') (Note: it might be better to signal this with a services bit in the version message) |
There was a problem hiding this comment.
Yes, please, consider using the services bit. Implementation wise, a client wanting to connect to a segwit supported node, don't want the need to wait for a magic timeout period to know if the node support segwit before trying the next one.
Using a message 'havewitness' will make peer discovery magnitude time longer.
luke-jr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs BIP number