-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIP 2: Allow editors to fix typos #596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a worthwhile and positive addition IMHO.
@luke-jr If this can't be implemented easily in GitHub's system, I'm willing to help out by watching for these kinds of Pull Requests and then fast-tracking them in when they are only spelling/grammar corrections (after a quick read of them first, of course). |
Nobody's approval matters other than the author of the BIP being modified (unless it's s a Final/Active BIP, in which case the usual requirements apply also). Approving changes you don't have authority to approve is at best a waste of time. :/ |
I'm in support of this, perhaps requiring sign off from multiple BIP contributors (not necessarily the BIP author) that the meaning is unchanged, as suggested by cdecker. |
This would be a good idea since it wouldn't waste people's time to ACK trivial stuff and also if the contributor(s) of the BIP(s) is/are not available, it prevents merging trivial fixes. |
ACK. |
Hi @luke-jr, it would be nice to move this forward. Here is a summary: @kanzure :
@Sjors :
Jean-Paul Kogelman :
@cdecker :
|
I got the impression there isn't consensus for this change. @kanzure's requirements in particular seem to make it more effort than it's worth, so I'm inclined to just close the PR... OTOH, maybe I should point out that these are just documents, and if there's ever a problem, things can be reverted with little harm...? |
I'm happy for editors to fix typos even without kanzure's requirements.
Check PGP signatures if you want to be totally sure.
…On December 31, 2018 7:25:56 AM UTC, Luke Dashjr ***@***.***> wrote:
I got the impression there isn't consensus for this change. @kanzure's
requirements in particular seem to make it more effort than it's worth,
so I'm inclined to just close the PR...
OTOH, maybe I should point out that these are just documents, and if
there's ever a problem, things can be reverted with little harm...?
--
https://petertodd.org 'peter'[:-1]@petertodd.org
|
I'd be fine with simply requiring that changes be pgp signed (although it might reduce participation a bit). Remember, this is only about fixing obvious typos and everything will be recorded in git history. |
Oh! I'm ok with both allowing editors to use their judgement in fixing typos, and not requiring PGP signatures on contributions.
These are after all just design docs; leave it up to the authors to decide if they want the security of a PGP signature on their contributions. It's mostly their problem after all as the harm would be to their reputation.
I'm signing (and timestamping) all of mine!
…On January 1, 2019 4:37:34 PM UTC, Jonathan Cross ***@***.***> wrote:
I'd be fine with simply requiring that changes be pgp signed (although
it might reduce participation a bit). Remember, this is only about
fixing obvious typos and everything will be recorded in git history.
--
https://petertodd.org 'peter'[:-1]@petertodd.org
|
I would consider it a strict improvement if BIP editors had permission to merge non-meaning changing PRs to BIPs. |
I agree with this and would like something closer to this language to land in the actual proposed change. As it stands right now the diff suggests something more vague than what @murchandamus writes here. |
ACK ce5d831 I agree with @murchandamus as well. |
I'd rather prefer using some kind of layers or ignorelists in order to
leave those PRs on hold indefinitely while sticking to process, but I think
that would imply migrating the ticket system finally (I appreciate 0xb10c
work about that), so for the sake of collaborators sanity, I would hope for
allowing BIP editors to merge typos **as a temporary measure only in effect
as long as the community is still using GitHub as issue tracker**
…On Tue, Apr 23, 2024 at 6:40 PM murchandamus ***@***.***> wrote:
I would consider it a strict improvement if BIP editors had permission to
merge non-meaning changing PRs to BIPs.
Permitted should be to fix a typo or a broken link (where it can be
adjusted to link to the new location of the original document). Not
permitted without sign-off from the authors should be changing any words or
adding punctuation.
—
Reply to this email directly, view it on GitHub
<#596 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRS4W4ZHLWEDRI7TQCASWLY62TJFAVCNFSM4D4Y6FJ2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBXGMYTKOJSGU3A>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
ACK As an author of several BIPs with far too many typos, I wholeheartedly agree with this change. |
ACK |
Please see https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-September/015065.html