Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese wordlist #720

Closed
wants to merge 28 commits into from
Closed

Add Portuguese wordlist #720

wants to merge 28 commits into from

Conversation

brenorb
Copy link
Contributor

@brenorb brenorb commented Aug 31, 2018

  1. Length between 4 and 8 characters.
  2. Words can be uniquely determined typing the first 4 characters.
  3. No accents or special characters.
  4. No complex verb forms.
  5. No plural words, unless there's no singular form.
  6. No words with common double spelling, except when the only change is the accent.
  7. No words with the exact sound of another word with different spelling.
  8. No offensive words.
  9. No words already used in other language mnemonic sets.
  10. The words which have not the same spelling in Brazil and in Portugal are excluded.

@johnnyasantoss
Copy link

Thanks for doing this!

@murtagha

This comment has been minimized.

@luke-jr
Copy link
Member

luke-jr commented Sep 7, 2018

@DonaldTsang DonaldTsang mentioned this pull request Dec 26, 2018
22 tasks
@johnnyasantoss
Copy link

Hey! 👋 @luke-jr
Who can review this PR? Would someone that is not a core dev be able to review this? Given that it is in another language and requires specific knowledge.

@luke-jr
Copy link
Member

luke-jr commented Sep 19, 2019

Only the authors can approve

Copy link
Member

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer, I'm Portuguese.

jato
javali
jazida
jeca
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Brazilian words should be replaced? For instance, this one https://www.infopedia.pt/dicionarios/lingua-portuguesa/jeca

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it too unfamiliar for Portuguese people? For me, this one of the major rules: does someone needs to look at a dictionary to know what the word is/how is it spelled?
I'm not in love with any particular word, so we can change any of them if we can find a nice substitute.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also Portuguese and can confirm that this word is unknown in Portugal, I even checked with older family members and they've never heard it before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but a newer and better version got merged already: #998

jegue
jeito
jejum
jenipapo
Copy link
Member

@promag promag Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another example https://www.infopedia.pt/dicionarios/lingua-portuguesa/jenipapo. Well maybe this one is ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a fruit and there's no other name in Portugal I think it's ok to leave it there.
But if it's too strange for someone from Portugal we could think about replacing, maybe as low priority. The only thing is that it is now becoming hard to find good words that don't match previous word lists from other languages.

Also, another rule I didn't explicitly wrote (because it's not strictly followed) is that I tried to write mainly concrete nouns so people could use even photos to describe their seed. I think the less abstract the better. It was very hard to come up with this whole list, so maybe we won't be able to follow this rule for further replacements. But let's do our best.

@brenorb
Copy link
Contributor Author

brenorb commented Sep 19, 2019

@promag I really appreciate your review. I tried to reach Portuguese friends before to review the list I created but they weren't interested in doing it.

I believe we can do a single word list for Brazil and Portugal. I checked for words that could have a great difference in spelling like "fato" and "facto", and also avoided words with special characters like "sinônimo" which I believe is "sinónimo" in Portugal.

I don't believe Portugal have another word for jenipapo, if you do, please tell me.

If possible, I suggest you to review to whole list with your Portuguese perspective so we can come to a mid-term for both countries.

@promag
Copy link
Member

promag commented Sep 19, 2019

@brenorb sure.

apto
arame
aranha
arapuca
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brazilian, replace? See https://dicionario.priberam.org/arapuca.

arsenal
arvoredo
aspargo
aspecto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also be written as aspeto. Maybe replace? See https://dicionario.priberam.org/aspecto.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to replace this one, for sure. I didn't realize you guys use aspeto. Suggestions?
I'll reply the other ones shortly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aspersor as alternative?

@mrbianchi
Copy link

Why dont merge?

@luke-jr
Copy link
Member

luke-jr commented Aug 20, 2020

No authors have approved it

@brenorb
Copy link
Contributor Author

brenorb commented Aug 22, 2020

The authors, you mean them, right?
https://github.com/orgs/bitcoin/people

@luke-jr
Copy link
Member

luke-jr commented Oct 5, 2020

No. The authors are listed at the top of the BIP.

@brenorb brenorb closed this Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants