Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brazilian portuguese wordlist to BIP39 #654

Closed
wants to merge 1 commit into from

Conversation

kuthullu
Copy link
Contributor

The wordlist consists of 2048 non offensive, manually picked brazilian portuguese words.

Also edited the README with a small note about the work done.

@luke-jr
Copy link
Member

luke-jr commented Apr 1, 2018

@prusnak
Copy link
Contributor

prusnak commented Apr 2, 2018

I don't care about this lists. The only list I support is the English one.

@guilhermep
Copy link

I think this list should not contain words in common with the other wordlists, following the precedent set by the spanish, italian and french lists and maintaining the possibility to detect the language with just one word.

@brenorb
Copy link
Contributor

brenorb commented Jun 15, 2018

I suggest changing the word "abdome" and other words which have more than one possible orthography in portuguese.

@johnnyasantoss
Copy link

Is there any progress with this PR?
I agree with @brenorb argument about having words that may cause confusion.

@luke-jr
Copy link
Member

luke-jr commented Aug 9, 2018

One or more of the authors is needed to approve any modifications.

Copy link
Contributor

@brenorb brenorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no time to review the entire list, but this contribution seeks to pointing some words which might cause some confusion in Portuguese language.

I suggest discarding these ones and others which might have a similiar problem and picking new ones.

abutre
acaso
acelga
acento
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing words like "abdome" which can be written in more than one form, and words like "acento", which sounds identical to "assento".

bip-0039/portuguese_brazilian.txt Show resolved Hide resolved
bota
boteco
boxe
brabo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds very similar to "bravo", which is widely more used.

couve
covarde
coveiro
coxa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds identical to "cocha".

@kuthullu kuthullu closed this Aug 9, 2018
@kuthullu kuthullu deleted the portuguese_brazilian branch August 9, 2018 20:20
@brenorb
Copy link
Contributor

brenorb commented Aug 31, 2018

I worked some weeks in kuthullu's list to fix these issues and submitted a pull request #720 now with these rules:

  1. Length between 4 and 8 characters.
  2. Words can be uniquely determined typing the first 4 characters.
  3. No accents or special characters.
  4. No complex verb forms.
  5. No plural words, unless there's no singular form.
  6. No words with common double spelling, except when the only change is the accent.
  7. No words with the exact sound of another word with different spelling.
  8. No offensive words.
  9. No words already used in other language mnemonic sets.
  10. The words which have not the same spelling in Brazil and in Portugal are excluded.

@iancoleman
Copy link
Contributor

@successhalf, asking once is enough. You asked the exact same question 4 times. I've responded to you in iancoleman/bip39#261

iancoleman/bip39#261
iancoleman/bip39#144 (comment)
iancoleman/bip39#230 (comment)

@DonaldTsang DonaldTsang mentioned this pull request Dec 24, 2018
22 tasks
@DonaldTsang
Copy link

@brenorb you ready to restart the wordlist optimization project?

@brenorb
Copy link
Contributor

brenorb commented Dec 25, 2018

@brenorb you ready to restart the wordlist optimization project?

Well, @DonaldTsang, it's already done right here: #720
What are you planning?

@tonnon
Copy link

tonnon commented Aug 20, 2019

Any updates to add the Portuguese wordlist?

@brenorb
Copy link
Contributor

brenorb commented Aug 21, 2019

Any updates to add the Portuguese wordlist?

It's been a year waiting for reviews. It's all done here: #720

@johnnyasantoss
Copy link

Who can review that? I don't know any core dev that speaks/understands Portuguese.

@brenorb
Copy link
Contributor

brenorb commented Aug 21, 2019

Who can review that? I don't know any core dev that speaks/understands Portuguese.

No one needs to be a core dev to review this PR. If you speek Portuguese I deeply encourage you to review it and leave a comment so they can properly accept or reject the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants