-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brazilian portuguese wordlist to BIP39 #654
Conversation
I don't care about this lists. The only list I support is the English one. |
I think this list should not contain words in common with the other wordlists, following the precedent set by the spanish, italian and french lists and maintaining the possibility to detect the language with just one word. |
I suggest changing the word "abdome" and other words which have more than one possible orthography in portuguese. |
Is there any progress with this PR? |
One or more of the authors is needed to approve any modifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had no time to review the entire list, but this contribution seeks to pointing some words which might cause some confusion in Portuguese language.
I suggest discarding these ones and others which might have a similiar problem and picking new ones.
abutre | ||
acaso | ||
acelga | ||
acento |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest changing words like "abdome" which can be written in more than one form, and words like "acento", which sounds identical to "assento".
bota | ||
boteco | ||
boxe | ||
brabo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds very similar to "bravo", which is widely more used.
couve | ||
covarde | ||
coveiro | ||
coxa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds identical to "cocha".
I worked some weeks in kuthullu's list to fix these issues and submitted a pull request #720 now with these rules:
|
@successhalf, asking once is enough. You asked the exact same question 4 times. I've responded to you in iancoleman/bip39#261 iancoleman/bip39#261 |
@brenorb you ready to restart the wordlist optimization project? |
Well, @DonaldTsang, it's already done right here: #720 |
Any updates to add the Portuguese wordlist? |
It's been a year waiting for reviews. It's all done here: #720 |
Who can review that? I don't know any core dev that speaks/understands Portuguese. |
No one needs to be a core dev to review this PR. If you speek Portuguese I deeply encourage you to review it and leave a comment so they can properly accept or reject the PR. |
The wordlist consists of 2048 non offensive, manually picked brazilian portuguese words.
Also edited the README with a small note about the work done.