add BANK Wallet to supported wallets list #749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bip-0044.mediawiki
Outdated
| @@ -275,6 +275,7 @@ is required and a pull request to the above file should be created. | |||
| * [[https://www.ledgerwallet.com/|Ledger Wallet]] ([[https://github.com/LedgerHQ|source]]) | |||
| * [[https://21.co/learn/21-lib-wallet/|21 Machine Wallet]] ([[https://github.com/21dotco|source]]) | |||
| * [[https://trustwalletapp.com/|Trust Wallet]] ([[http://github.com/trustWallet/|source]]) | |||
| * [[https://horizontalsystems.io/dapps/bank-wallet/ | BANK Wallet]] ([[https://github.com/horizontalsystems/bank-wallet-ios/|iOS Sources ]]) / ([[https://github.com/horizontalsystems/bank-wallet-android/|Android Sources ]]) | |||
There was a problem hiding this comment.
Please remove extra spaces: before closing bracket ], before and after the pipe | -- they result in a broken link.
There was a problem hiding this comment.
The other wallets in this list use "source" (singular, lowercase).
For consistency, please also use "source" rather than "Sources".
|
I would remove all wallets from the BIP. It's hard to find a wallet which does not use BIP-44 nowadays and obviously, I don't want to maintain the list of all wallets in BIP-44. |
|
@luke-jr please close |
TreyChimi5252
approved these changes
May 20, 2019
TreyChimi5252
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.