Skip to content

Commit

Permalink
Merge #11585: addrman: Add missing lock in Clear() (CAddrMan)
Browse files Browse the repository at this point in the history
3ab545d addrman: Add missing lock in Clear() (CAddrMan) (practicalswift)

Pull request description:

  Add missing lock in `Clear()` (`CAddrMan`).

  The variable `vRandom` is guarded by the mutex `cs`.

  **Note to reviewers:** Does this look correct? Should the lock cover the entire scope of the method, or should it be limited to cover only `std::vector<int>().swap(vRandom);`?

Tree-SHA512: 8833f31beaed1728fa55b13ddf9e0b8e24e395931497329be2440ce1c5113ff02871707d40830260adabd30c4ea86088f5da5cf8a821150c0d820f50a2ce386a
  • Loading branch information
MarcoFalke committed Nov 7, 2017
2 parents ffc0b11 + 3ab545d commit 5aeaa9c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/addrman.h
Expand Up @@ -455,6 +455,7 @@ class CAddrMan

void Clear()
{
LOCK(cs);
std::vector<int>().swap(vRandom);
nKey = GetRandHash();
for (size_t bucket = 0; bucket < ADDRMAN_NEW_BUCKET_COUNT; bucket++) {
Expand Down

0 comments on commit 5aeaa9c

Please sign in to comment.