Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add regtest for JSON-RPC batch calls #14777

Merged
merged 1 commit into from Nov 22, 2018
Merged

tests: Add regtest for JSON-RPC batch calls #14777

merged 1 commit into from Nov 22, 2018

Conversation

domob1812
Copy link
Contributor

This adds a new regtest file interface_rpc.py, containing a test for batch JSON-RPC requests. Those were previously not tested at all. Tests for basic requests are not really necessary, as those are used anyway in lots of other regtests.

The existing interface_http.py file is more about the underlying HTTP connection, so adding a new interface file for the JSON-RPC specific things makes sense.

promag
promag reviewed Nov 21, 2018
View reviewed changes
Copy link
Member

@promag promag left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered adding batch support to AuthServiceProxy?

Edit: nervermind, see @laanwj comment below #14777 (review).

test/functional/interface_rpc.py Outdated Show resolved Hide resolved
@fanquake fanquake added the Tests label Nov 21, 2018
@laanwj
Copy link
Member

laanwj commented Nov 21, 2018

There's a test for batching added in 4526d21, but it's part of the wallet tests so adding a general one is probably good.

@domob1812 domob1812 force-pushed the batch-rpc branch 2 times, most recently from 5e858fd to 4197031 Compare November 21, 2018 15:07
@laanwj
Copy link
Member

laanwj commented Nov 21, 2018

utACK 06ffc4b19b8ca8a8173caf5d3e90d0651e22d72d

promag
promag reviewed Nov 21, 2018
View reviewed changes
Copy link
Member

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 06ffc4b, just some nits.

test/functional/interface_rpc.py Outdated Show resolved Hide resolved
test/functional/interface_rpc.py Outdated Show resolved Hide resolved
test/functional/interface_rpc.py Show resolved Hide resolved
@promag
Copy link
Member

promag commented Nov 21, 2018

Where is Travis?

promag
promag reviewed Nov 21, 2018
View reviewed changes
Copy link
Member

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fixes @domob1812, looks great! just left 2 more comments.

test/functional/interface_rpc.py Show resolved Hide resolved
test/functional/interface_rpc.py Outdated Show resolved Hide resolved
@domob1812
Add regtest for JSON-RPC batch calls.
3d2c7d6 
This adds a new regtest file 'interface_rpc.py', containing a test for
batch JSON-RPC requests.  Those were previously not tested at all.  Tests
for basic requests are not really necessary, as those are used anyway
in lots of other regtests.

The existing interface_http.py file is more about the underlying HTTP
connection, so adding a new interface file for the JSON-RPC specific
things makes sense.
@promag
Copy link
Member

promag commented Nov 21, 2018

utACK 3d2c7d6.

@Empact
Copy link
Member

Empact commented Nov 22, 2018

utACK 3d2c7d6

@maflcko maflcko merged commit 3d2c7d6 into bitcoin:master Nov 22, 2018
maflcko pushed a commit that referenced this pull request Nov 22, 2018
Merge #14777: tests: Add regtest for JSON-RPC batch calls
3dda4c5 
3d2c7d6 Add regtest for JSON-RPC batch calls. (Daniel Kraft)

Pull request description:

  This adds a new regtest file `interface_rpc.py`, containing a test for batch JSON-RPC requests.  Those were previously not tested at all.  Tests for basic requests are not really necessary, as those are used anyway in lots of other regtests.

  The existing `interface_http.py` file is more about the underlying HTTP connection, so adding a new interface file for the JSON-RPC specific things makes sense.

Tree-SHA512: 7c7576004c8474e23c98f4bf25fb655328ba6bb73ea06744ebee1c0ffbb26bc132e621ae52955d51dab0803b322f8d711667626a777ac9b26003339c2484502f
@domob1812 domob1812 deleted the batch-rpc branch November 22, 2018 19:19
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jul 29, 2021
@Munkybooty
Merge bitcoin#14777: tests: Add regtest for JSON-RPC batch calls
3ed8288 
3d2c7d6 Add regtest for JSON-RPC batch calls. (Daniel Kraft)

Pull request description:

  This adds a new regtest file `interface_rpc.py`, containing a test for batch JSON-RPC requests.  Those were previously not tested at all.  Tests for basic requests are not really necessary, as those are used anyway in lots of other regtests.

  The existing `interface_http.py` file is more about the underlying HTTP connection, so adding a new interface file for the JSON-RPC specific things makes sense.

Tree-SHA512: 7c7576004c8474e23c98f4bf25fb655328ba6bb73ea06744ebee1c0ffbb26bc132e621ae52955d51dab0803b322f8d711667626a777ac9b26003339c2484502f
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jul 29, 2021
@Munkybooty
Merge bitcoin#14777: tests: Add regtest for JSON-RPC batch calls
4e82f0b 
3d2c7d6 Add regtest for JSON-RPC batch calls. (Daniel Kraft)

Pull request description:

  This adds a new regtest file `interface_rpc.py`, containing a test for batch JSON-RPC requests.  Those were previously not tested at all.  Tests for basic requests are not really necessary, as those are used anyway in lots of other regtests.

  The existing `interface_http.py` file is more about the underlying HTTP connection, so adding a new interface file for the JSON-RPC specific things makes sense.

Tree-SHA512: 7c7576004c8474e23c98f4bf25fb655328ba6bb73ea06744ebee1c0ffbb26bc132e621ae52955d51dab0803b322f8d711667626a777ac9b26003339c2484502f
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Aug 3, 2021
@Munkybooty
Merge bitcoin#14777: tests: Add regtest for JSON-RPC batch calls
af3bb18 
3d2c7d6 Add regtest for JSON-RPC batch calls. (Daniel Kraft)

Pull request description:

  This adds a new regtest file `interface_rpc.py`, containing a test for batch JSON-RPC requests.  Those were previously not tested at all.  Tests for basic requests are not really necessary, as those are used anyway in lots of other regtests.

  The existing `interface_http.py` file is more about the underlying HTTP connection, so adding a new interface file for the JSON-RPC specific things makes sense.

Tree-SHA512: 7c7576004c8474e23c98f4bf25fb655328ba6bb73ea06744ebee1c0ffbb26bc132e621ae52955d51dab0803b322f8d711667626a777ac9b26003339c2484502f
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Aug 5, 2021
@Munkybooty
Merge bitcoin#14777: tests: Add regtest for JSON-RPC batch calls
7c8f0e5 
3d2c7d6 Add regtest for JSON-RPC batch calls. (Daniel Kraft)

Pull request description:

  This adds a new regtest file `interface_rpc.py`, containing a test for batch JSON-RPC requests.  Those were previously not tested at all.  Tests for basic requests are not really necessary, as those are used anyway in lots of other regtests.

  The existing `interface_http.py` file is more about the underlying HTTP connection, so adding a new interface file for the JSON-RPC specific things makes sense.

Tree-SHA512: 7c7576004c8474e23c98f4bf25fb655328ba6bb73ea06744ebee1c0ffbb26bc132e621ae52955d51dab0803b322f8d711667626a777ac9b26003339c2484502f
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Aug 8, 2021
@Munkybooty
Merge bitcoin#14777: tests: Add regtest for JSON-RPC batch calls
cdad567 
3d2c7d6 Add regtest for JSON-RPC batch calls. (Daniel Kraft)

Pull request description:

  This adds a new regtest file `interface_rpc.py`, containing a test for batch JSON-RPC requests.  Those were previously not tested at all.  Tests for basic requests are not really necessary, as those are used anyway in lots of other regtests.

  The existing `interface_http.py` file is more about the underlying HTTP connection, so adding a new interface file for the JSON-RPC specific things makes sense.

Tree-SHA512: 7c7576004c8474e23c98f4bf25fb655328ba6bb73ea06744ebee1c0ffbb26bc132e621ae52955d51dab0803b322f8d711667626a777ac9b26003339c2484502f
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Aug 9, 2021
@Munkybooty
Merge bitcoin#14777: tests: Add regtest for JSON-RPC batch calls
b781865 
3d2c7d6 Add regtest for JSON-RPC batch calls. (Daniel Kraft)

Pull request description:

  This adds a new regtest file `interface_rpc.py`, containing a test for batch JSON-RPC requests.  Those were previously not tested at all.  Tests for basic requests are not really necessary, as those are used anyway in lots of other regtests.

  The existing `interface_http.py` file is more about the underlying HTTP connection, so adding a new interface file for the JSON-RPC specific things makes sense.

Tree-SHA512: 7c7576004c8474e23c98f4bf25fb655328ba6bb73ea06744ebee1c0ffbb26bc132e621ae52955d51dab0803b322f8d711667626a777ac9b26003339c2484502f
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Aug 11, 2021
@Munkybooty
Merge bitcoin#14777: tests: Add regtest for JSON-RPC batch calls
b45c353 
3d2c7d6 Add regtest for JSON-RPC batch calls. (Daniel Kraft)

Pull request description:

  This adds a new regtest file `interface_rpc.py`, containing a test for batch JSON-RPC requests.  Those were previously not tested at all.  Tests for basic requests are not really necessary, as those are used anyway in lots of other regtests.

  The existing `interface_http.py` file is more about the underlying HTTP connection, so adding a new interface file for the JSON-RPC specific things makes sense.

Tree-SHA512: 7c7576004c8474e23c98f4bf25fb655328ba6bb73ea06744ebee1c0ffbb26bc132e621ae52955d51dab0803b322f8d711667626a777ac9b26003339c2484502f
5tefan pushed a commit to 5tefan/dash that referenced this pull request Aug 12, 2021
@5tefan
Merge bitcoin#14777: tests: Add regtest for JSON-RPC batch calls
2aea05b 
3d2c7d6 Add regtest for JSON-RPC batch calls. (Daniel Kraft)

Pull request description:

  This adds a new regtest file `interface_rpc.py`, containing a test for batch JSON-RPC requests.  Those were previously not tested at all.  Tests for basic requests are not really necessary, as those are used anyway in lots of other regtests.

  The existing `interface_http.py` file is more about the underlying HTTP connection, so adding a new interface file for the JSON-RPC specific things makes sense.

Tree-SHA512: 7c7576004c8474e23c98f4bf25fb655328ba6bb73ea06744ebee1c0ffbb26bc132e621ae52955d51dab0803b322f8d711667626a777ac9b26003339c2484502f
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laanwj laanwj laanwj left review comments

@promag promag promag left review comments

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@domob1812 @laanwj @promag @Empact @fanquake @maflcko