Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant 'solved' from ProduceSignature #15274

Closed
wants to merge 1 commit into from

Conversation

fivepiece
Copy link
Contributor

We only enter the if blocks if solved is true.
The && inside seems redundant

We only enter the 'if' blocks if 'solved' is true.
The '&&' inside is redundant
Copy link
Member

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduced in #8149 by @sipa, it is indeed unnecessary. No harm keeping them though.

utACK 5579bb1.

@Empact
Copy link
Member

Empact commented Jan 28, 2019

It's slightly protective in that it guards against the unintentional introduction of a new case that overwrites a false solved. assert could be more helpful if we want to continue to guard against that though.

@laanwj
Copy link
Member

laanwj commented Jan 31, 2019

No harm keeping them though.

It's slightly protective in that it guards against the unintentional introduction of a new case that overwrites a false solved

Meh. Tend towards NACK, I see no strong need to change this code, sorry.

@laanwj laanwj closed this Feb 4, 2019
@jonasschnelli
Copy link
Contributor

Agree with @laanwj and @Empact.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants