-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warning='45 of last 100 blocks have unexpected version' #16343
Comments
Bitcoin Core does not expect that miners are setting those versions, which is why it is logged. See also
|
Maybe |
I tend to agree it's useless information at this point, I'd venture removing it completely, or only showing it if some logging debug flag is enabled. Usually we follow the principle that we don't want to have any things in the log by default that might worry users unnecessarily. |
Miners are essentially disregarding the protocol rules and stuffing bogus information into the version field without any sort of community consensus. Perhaps the right solution is a softfork to make these bits invalid. |
Does not sound good... |
That's absolutely true, but also I think, not really something that most users need to be bothered with constantly. |
It is necessary for users to safeguard the protocol against malicious miners. Without the ability to enforce this as a protocol rule, the best we can do is warn. Without even a warning, users can't do their job of protecting the protocol at all. |
I don't think it's a matter of black and white, yes, 'stealing' version bits for ASICboost was a absolutely controversial, at the time. On the other hand, it's well known and documented now. It has no adverse effect on the network. The only thing it does, concretely, is cause these warnings. |
It has at least three adverse affects:
|
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues. Closing due to lack of interest. Pull requests with improvements are always welcome. |
The client needs to decide if this is worthy of notifying the user about and cluttering the log page. Seems clear these warnings should be merely verbose log items most people never need to see because these warnings are now so common practice they are never going to disappear. i.e. If the client isn't going to start rejecting the blocks (which let's face it, would be insane to hardfork over) this warning is unnecessarily concerning new users of bitcoin. As a suggestion, perhaps we could just say |
@sradforth I feel your pain! Thanks for sharing your experience. You might want to leave a comment (or perhaps "Concept ACK") in the open issue #19603 ( |
@luke-jr "Transforming SHA2 from an ASIC-friendly PoW algorithm to an ASIC-complex algorithm" - can you provide a source for this please? I would say for this issue, as it's less than 50, it's a non issue, and that consensus is not reached for a protocol change, and Core should not adapt to the malpractice, whereas if it was over 50, then the miners have spoken, and Core perhaps should adapt to the new consensus. |
@rebroad See ASICBoost.
Miners do not decide protocol changes. |
From my current point of view it was a warning and should be one again, if changed. Maybe also a reopening? |
Of course they do. Consensus is the foundation of the network and miners are the only consensus that matters. Nobody else can enforce the protocol if the miners do not cooperate. If a majority of miners decide they are going to change the protocol, it's changed. If enough miners disagree with the change then we have a fork. The only question that remains is which (or if) one of the forks will die. The one thing that prevents miners from taking over the network thus far is self-interest. Meaning, thus far it has been judged to be more profitable to let Core set the rules, more or less. That balance may change. For example, perhaps miners will decide "no more halving" and so maintain block rewards while causing a permanent inflation. |
I agree with the first sentence. Miners are the first part of consensus, the "chain-robustness" will be given by the validation of every participating node. Otherwise the chain/token-connection makes no sense in the law of satoshis paper. |
Saw a 70... yesterday |
|
See d82b2c6 |
Hello everyone:
I am running:
{
"version": 180000,
"protocolversion": 70015,
"walletversion": 169900,
In the debug log I get:
2019-07-05T05:47:37Z UpdateTip: new best=00000000000000000006a8e968937ed0d26cba95af48aec9a35030dae34068ea height=583923 version=0x20000000 log2_work=90.811056 tx=431748422 date='2019-07-05T05:47:31Z' progress=1.000000 cache=67.4MiB(597483txo) warning='43 of last 100 blocks have unexpected version
As I am running version 0.18, I would have expected this kind of message go away, as the message "unknown version"was deactivated in the latest release.
What is the difference between "unexpected version" and "unknown version"?
Why one warning has been suppressed with latest release and the other is still present (and quite common as I can see?)
This different approach on very similar errors is generating user confusion.
Thank you.
The text was updated successfully, but these errors were encountered: