Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: afl fuzzing comment about afl-gcc and afl-g++ #19452

Merged
merged 1 commit into from Jul 9, 2020

Conversation

Crypt-iQ
Copy link
Contributor

@Crypt-iQ Crypt-iQ commented Jul 6, 2020

When trying to build the fuzz tests with --enable-lcov on a Ubuntu machine, noticed that the documentation was lacking with regards to the afl-gcc and afl-g++ options. afl-clang-fast and afl-clang-fast++ in the examples just need to be replaced with afl-gcc and afl-g++. I also had to set the -m flag as well to get the fuzzers to run.

This commit includes a short comment in doc/fuzzing.md that gives
guidance on compiling Bitcoin Core with AFL instrumentation using
afl-gcc and afl-g++.
@fanquake fanquake added the Docs label Jul 6, 2020
@maflcko
Copy link
Member

maflcko commented Jul 6, 2020

Concept ACK 2b78a11, haven't tested

@practicalswift
Copy link
Contributor

ACK 2b78a11

Great first-time contribution @Crypt-iQ - welcome as a contributor!

Very exciting to see the number of people actively fuzzing Bitcoin Core grow :)

@fanquake fanquake merged commit 45f58db into bitcoin:master Jul 9, 2020
@Crypt-iQ Crypt-iQ deleted the afl_gcc_0705 branch July 9, 2020 13:54
@laanwj
Copy link
Member

laanwj commented Jul 9, 2020

Thanks for your first contribution but

Author:     nsa <e…@gmail.com>
AuthorDate: Sun Jul 5 20:55:11 2020 -0400
Commit:     nsa <e…@gmail.com>
CommitDate: Sun Jul 5 20:55:11 2020 -0400

lol
Nice troll but I think you might want to set a different author name in your git configuration.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 9, 2020
2b78a11 doc: afl fuzzing comment about afl-gcc and afl-g++ (nsa)

Pull request description:

  When trying to build the fuzz tests with `--enable-lcov` on a Ubuntu machine, noticed that the documentation was lacking with regards to the afl-gcc and afl-g++ options. `afl-clang-fast` and `afl-clang-fast++` in the examples just need to be replaced with `afl-gcc` and `afl-g++`. I also had to set the `-m` flag as well to get the fuzzers to run.

ACKs for top commit:
  practicalswift:
    ACK 2b78a11
  MarcoFalke:
    Concept ACK 2b78a11, haven't tested

Tree-SHA512: d8151afd79de949e8c6da49b69bbbf1470eb478c8ddcbc69b30e86bf9396c0f13835a655d4ae658f7dc4f36c35b02cd23b08358fb73a71e15bf14e76c1f365a4
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants