Revert "Add patch to make codesign_allocate compatible with Apple's" #20855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a4118c6.
Bayrsaikhan12
approved these changes
Jan 5, 2021
whiteslack
approved these changes
Jan 5, 2021
|
ACK a0eb4c5 |
laanwj
approved these changes
Jan 5, 2021
|
Reference from IRC: |
|
checked-clean-revert ACK a0eb4c5 |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jan 5, 2021
This reverts commit a4118c6. Github-Pull: bitcoin#20855 Rebased-From: a0eb4c5
|
Backported in #20850 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 5, 2021
…atible with Apple's" a0eb4c5 Revert "Add patch to make codesign_allocate compatible with Apple's" (Pieter Wuille) Pull request description: This reverts bitcoin#20644. It appears that Apple has recently changed their `codesign_allocate` tool back to using 4k alignment on x86_64, at least in some cases, so this patch isn't causing our cctools-based version to be exactly compatible. Furthermore, if codesigning were to change to use https://github.com/achow101/signapple instead, there is no need anymore to try to mimick Apple. ACKs for top commit: laanwj: ACK a0eb4c5 MarcoFalke: checked-clean-revert ACK a0eb4c5 jonasschnelli: ACK a0eb4c5 Tree-SHA512: 529719a76811006122406689233d1e80995107fe1ac1fc862a4ac53ca21685748ed76cac7ca648dd70f0ea43dd8dcf2e29d559beeab10e1d30dc5542ac95fd97
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #20644.
It appears that Apple has recently changed their
codesign_allocatetool back to using 4k alignment on x86_64, at least in some cases, so this patch isn't causing our cctools-based version to be exactly compatible.Furthermore, if codesigning were to change to use https://github.com/achow101/signapple instead, there is no need anymore to try to mimick Apple.