refactor: Treat ArgsManager::Flags as uint32_t explicitly #21082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All ci runs fail and look like: https://cirrus-ci.com/task/5428847116025856?command=ci#L4505 |
|
cr ACK faf3b4b More generally I think we should increase our use of the fixed-width integer types. Explicit is better than implicit. Gotcha-free is better than maybe-gotcha. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 5, 2021
…xplicitly faf3b4b refactor: Treat ArgsManager::Flags as uint32_t explicitly (MarcoFalke) Pull request description: The underlying type might be implementation defined, which is probably why the sanitizer kills the fuzz tests. Fix that by pinning the underlying type. This refactor does not change behaviour and only affects the sanitizer in tests. ACKs for top commit: practicalswift: cr ACK faf3b4b Tree-SHA512: d446824836e1037b4200ba3630c8628090678cfad45559866275d8e06349f7c8cdb7e816619f5afb35f9f65299cc00e046d2f81b73cd8eb843e2e15676b647d5
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 17, 2022
…xplicitly faf3b4b refactor: Treat ArgsManager::Flags as uint32_t explicitly (MarcoFalke) Pull request description: The underlying type might be implementation defined, which is probably why the sanitizer kills the fuzz tests. Fix that by pinning the underlying type. This refactor does not change behaviour and only affects the sanitizer in tests. ACKs for top commit: practicalswift: cr ACK faf3b4b Tree-SHA512: d446824836e1037b4200ba3630c8628090678cfad45559866275d8e06349f7c8cdb7e816619f5afb35f9f65299cc00e046d2f81b73cd8eb843e2e15676b647d5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying type might be implementation defined, which is probably why the sanitizer kills the fuzz tests.
Fix that by pinning the underlying type.
This refactor does not change behaviour and only affects the sanitizer in tests.