-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove -deprecatedrpc=addresses flag and corresponding code/logic #21797
Comments
Intent is to add this issue to milestone 23.0. Not sure how to do this or if I'm able to |
Branch-off will be in about 60 days (#20851), after which this patch can be merged. Do you want to address this issue yourself or did you file this for someone else to pick up? |
I'd be happy to address the issue myself. Just figured I'd create an issue to make sure it isn't forgotten. Anyways I'll aim to have it ready around branch-off and open the PR then |
@mjdietzx Are you still working on this? |
Yessir, thanks for the heads up. Just opened the PR 😁 |
The following RPCs:
gettxout
,getrawtransaction
,decoderawtransaction
,decodescript
,gettransaction
, and REST endpoints:/rest/tx
,/rest/getutxos
,/rest/block
deprecated the following fields (which are nolonger returned in the responses by default):
addresses
,reqSigs
.The
-deprecatedrpc=addresses
flag must be passed for these fields to beincluded in the RPC response. This flag/option will be available until v23, at which
point the deprecation will be removed entirely. Note that these fields are attributes of
the
scriptPubKey
object returned in the RPC response. However, in the responseof
decodescript
these fields are top-level attributes, and included again as attributesof the
scriptPubKey
object.The original issue #20102 was resolved in this PR #20286, and from v23 ("addresses" and "reqSigs" deprecated) "ExtractDestinations" should be removed.
The text was updated successfully, but these errors were encountered: