Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -deprecatedrpc=addresses flag and corresponding code/logic #21797

Closed
mjdietzx opened this issue Apr 28, 2021 · 5 comments · Fixed by #22650
Closed

Remove -deprecatedrpc=addresses flag and corresponding code/logic #21797

mjdietzx opened this issue Apr 28, 2021 · 5 comments · Fixed by #22650
Milestone

Comments

@mjdietzx
Copy link
Contributor

The following RPCs: gettxout, getrawtransaction, decoderawtransaction,
decodescript, gettransaction, and REST endpoints: /rest/tx,
/rest/getutxos, /rest/block deprecated the following fields (which are no
longer returned in the responses by default): addresses, reqSigs.
The -deprecatedrpc=addresses flag must be passed for these fields to be
included in the RPC response. This flag/option will be available until v23, at which
point the deprecation will be removed entirely. Note that these fields are attributes of
the scriptPubKey object returned in the RPC response. However, in the response
of decodescript these fields are top-level attributes, and included again as attributes
of the scriptPubKey object.

The original issue #20102 was resolved in this PR #20286, and from v23 ("addresses" and "reqSigs" deprecated) "ExtractDestinations" should be removed.

@mjdietzx
Copy link
Contributor Author

Intent is to add this issue to milestone 23.0. Not sure how to do this or if I'm able to

@maflcko maflcko added this to the 23.0 milestone Apr 28, 2021
@maflcko
Copy link
Member

maflcko commented Apr 28, 2021

Branch-off will be in about 60 days (#20851), after which this patch can be merged. Do you want to address this issue yourself or did you file this for someone else to pick up?

@mjdietzx
Copy link
Contributor Author

I'd be happy to address the issue myself. Just figured I'd create an issue to make sure it isn't forgotten. Anyways I'll aim to have it ready around branch-off and open the PR then

@maflcko
Copy link
Member

maflcko commented Aug 6, 2021

@mjdietzx Are you still working on this?

@mjdietzx
Copy link
Contributor Author

mjdietzx commented Aug 6, 2021

Yessir, thanks for the heads up. Just opened the PR 😁

@bitcoin bitcoin locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@maflcko @mjdietzx and others