Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test_runner uses a UNIX-only Python function (os.killpg) #23085

Closed
darosior opened this issue Sep 24, 2021 · 2 comments
Closed

ci: test_runner uses a UNIX-only Python function (os.killpg) #23085

darosior opened this issue Sep 24, 2021 · 2 comments
Labels

Comments

@darosior
Copy link
Member

Encountered by the Win64 CI in #23074

Traceback (most recent call last):
  File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_runner.py", line 797, in <module>
    main()
  File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_runner.py", line 446, in main
    run_tests(
  File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_runner.py", line 567, in run_tests
    os.killpg(os.getpgid(0), signal.SIGKILL)
AttributeError: module 'os' has no attribute 'killpg'
@darosior darosior added the Bug label Sep 24, 2021
@hebasto
Copy link
Member

hebasto commented Sep 24, 2021

See:

@maflcko
Copy link
Member

maflcko commented Nov 15, 2021

Thanks for the report, however I am going to close this bug, as it has been removed from ci in #23513.

The bug still does exist on Windows, but I don't think we have any users on Windows that run the tests with --failfast. If I am wrong, please let me know and this bug can be reopened or a new one be opened.

@maflcko maflcko closed this as completed Nov 15, 2021
@bitcoin bitcoin locked and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants