Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add lint job to run clang-tidy check for named args #24747

Closed
fanquake opened this issue Apr 3, 2022 · 1 comment · Fixed by #24753
Closed

ci: add lint job to run clang-tidy check for named args #24747

fanquake opened this issue Apr 3, 2022 · 1 comment · Fixed by #24753

Comments

@fanquake
Copy link
Member

fanquake commented Apr 3, 2022

After #24661, we should be able to enable clang-tidy named argument checking in the CI lint job. The simplest way to invoke this checking, is something like ./autogen.sh && ./configure CC=clang-12 CXX=clang++-12 && make clean && bear make -j9 && ( cd ./src/ && run-clang-tidy-12 -j9 ), which invokes clang-tidy using our .clang-tidy config.

Dependencies, like clang-tidy would need to be installed in the linting container, and a linting job could be added to https://github.com/bitcoin/bitcoin/tree/master/test/lint.

It is possible to work on this now, by just basing your changes on the #24661 branch.

Useful skills:

  • Bash
  • CI

Want to work on this issue?

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

@maflcko
Copy link
Member

maflcko commented Apr 4, 2022

I think this requires a "mock" compilation so this will probably be a normal task, separate from the lint task.

@bitcoin bitcoin locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants