Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make test_utxo_snapshots.sh use signet #28619

Closed
Sjors opened this issue Oct 9, 2023 · 3 comments
Closed

test: make test_utxo_snapshots.sh use signet #28619

Sjors opened this issue Oct 9, 2023 · 3 comments

Comments

@Sjors
Copy link
Member

Sjors commented Oct 9, 2023

It currently requires recompiling, which doesn't seem necessary if we just use a lighter weight network like signet.

We could also drop this script entirely?

@Sjors
Copy link
Member Author

Sjors commented Oct 9, 2023

cc @jamesob do you think it's still useful?

If so I'll look into switching it to Signet.

@maflcko
Copy link
Member

maflcko commented Oct 10, 2023

I'd say for testing, the existing unit or functional test framework should be used. No objection for the bash script to exist, but I think longer term, it is clear that bash scripts won't be maintained in this repo, given that there are no reviewers for them and that the script is excluded from shellcheck completely (#27596 (comment)). Unit and functional test would at least run in the CI.

@fanquake
Copy link
Member

fanquake commented Mar 7, 2024

Going to close this, given we should be removing the bash scripts in #29553.

@fanquake fanquake closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants