-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc: improve submitpackage documentation and other improvements #29292
rpc: improve submitpackage documentation and other improvements #29292
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
34b5d5c
to
7e8d359
Compare
7e8d359
to
a77dc1b
Compare
a77dc1b
to
b2fb55c
Compare
b2fb55c
to
5a7a720
Compare
Rebased to master to make CI green, no changes otherwise. Thanks for the review @glozow, addressed all comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 5a7a720
This is ok to merge as is but if you decide to address 9deb910#r1476296848 I will quickly re-review.
5a7a720
to
311f523
Compare
Force pushed to incorporate the approach suggested in #29292 (comment) Apologies for the slow follow-up while I was on holidays, thank you for the review! |
re-ACK 311f523 Apologies for even slower re-review :) |
Currently, the only allowed package topology has a min size of 2. Update the error message to reflect that.
311f523
to
78e52f6
Compare
Force pushed to address @instagibbs's review, only very minor changes. |
ACK 78e52f6 only the suggested changes, verified via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 78e52f6
ACK 78e52f6 |
submitpackage
requires the package to be topologically sorted with the child being the last element in the array, but this is not documented in the RPC method or the error messages.Also sneaking in some other minor improvements that I found while going through the code:
package
needs to be an array of length between1
andMAX_PACKAGE_COUNT
is confusing whenIsChildWithPackage()
requires that the package size >= 2. Remove this check to avoid code duplication and sending a confusing error message.submitpackage
examples