Remove libbitcoinconsensus

[fanquake]

This was deprecated in v27.0, for removal in v28.0. See discussion in PR #29189.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	TheCharlatan, hebasto
Concept ACK	theuni, m3dwards

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #29494 (build: Assume HAVE_CONFIG_H, Add IWYU pragma keep to bitcoin-config.h includes by maflcko)
• #29221 (Implement 64 bit arithmetic op codes in the Script interpreter by Christewart)
• #29050 (Add OP_TXHASH and OP_CHECKTXHASHVERIFY opcodes by stevenroose)
• #29015 (kernel: Streamline util library by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[DrahtBot]

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

_{Debug: https://github.com/bitcoin/bitcoin/runs/22614510960}

[hebasto]

Concept ACK.

To fix MSVC build, suggesting:

--- a/build_msvc/libbitcoin_consensus/libbitcoin_consensus.vcxproj
+++ b/build_msvc/libbitcoin_consensus/libbitcoin_consensus.vcxproj
@@ -15,7 +15,6 @@
     <ClCompile Include="..\..\src\primitives\block.cpp" />
     <ClCompile Include="..\..\src\primitives\transaction.cpp" />
     <ClCompile Include="..\..\src\pubkey.cpp" />
-    <ClCompile Include="..\..\src\script\bitcoinconsensus.cpp" />
     <ClCompile Include="..\..\src\script\interpreter.cpp" />
     <ClCompile Include="..\..\src\script\script.cpp" />
     <ClCompile Include="..\..\src\script\script_error.cpp" />

[fanquake]

To fix MSVC build

Taken.

[TheCharlatan]

Just a small comment; seems good to go.

[TheCharlatan]

ACK 80f8b92

[theuni]

Concept ACK and light review ACK 80f8b92. My only hesitation here is that (afaics?) there's now nothing keeping undesired features like threading or globals from working their way into the interpreter in future commits.

Is there anything I'm missing in that regard? Otherwise, any ideas for checks to keep them out via c-i?

[m3dwards]

Concept ACK 80f8b92

I've tested this branch on MSVC, Mac and Debian and reviewed the changes.

I still feel a bit too green to this area to give stronger than concept ACK.

[hebasto]

ACK 80f8b92, I have reviewed the code and it looks OK.

[theuni]

I didn't mean for my comment above to be a blocker btw. I think we can just be vigilant in review about dependencies in the interpreter.

[fanquake]

Followup in #29787.