-
Notifications
You must be signed in to change notification settings - Fork 35.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitcoin-qt.exe gitian win32: missing icon and runs blank terminal window #3499
Comments
As for the console window: we need to add an For the icon I think we need to compile and link in the win32 resources file @theuni Do you have a suggestion on how to do this with autotools? |
AFAIK there are res files for bitcoind.exe and bitcoin-cli.exe already... IDI_ICON1 ICON DISCARDABLE "icons/bitcoin.ico" IDI_ICON2 ICON DISCARDABLE "icons/bitcoin_testnet.ico" |
The problem is that they aren't used. |
AFAIK @theuni added a patch, that they should be used some time ago? |
Ok, so But the gitian-built |
Must be a Gitian problem, as I have an icon and also no console window. |
@Diapolo can you confirm with self-built/gitian .exe's exactly what the issues are here? I'm happy to fix, but I'm in the dark without Windows. |
I don't Gitian build and (sorry) also didn't yet test the now merged Qt5 autotools patch (great work btw.). |
Note that the blank terminal window is not always blank -- it's the output (I don't know if it's stdout, stderr, or something else). I have -tor set in my config file, and the terminal window that opens with the GUI shows a message about the option being renamed to -onion in a future release. |
Indeed, the console window is Windows standard output, anything that's written to standard output ends up there. |
@theuni Do you have any recommendations on how to make sure that -mwindows is passed when linking bitcoin-qt.exe? I know how to do it, but maybe you have a preference as to how. |
If you want to distinguish between the two subsystem modes without Windows you can use the following commands: Good:
Wrong, should be GUI:
|
@laanwj Need to check -mwindows in configure before passing it along (AX_CHECK_LINK_FLAG), then pass it along in a GUI_FLAGS or so. I'll push up a patch in a few hours when I can build/test. |
Something changed with bitcoin-qt.exe built by gitian win32. The .exe is missing the Bitcoin icon and launching it opens a blank terminal window before the splash screen appears.
Built at 13e99e4
The text was updated successfully, but these errors were encountered: