Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insane fee check doesn't return clear error to the sendrawtransaction RPC #4341

Closed
Michagogo opened this issue Jun 15, 2014 · 9 comments
Closed

Comments

@Michagogo
Copy link
Contributor

Rather than a message that's readable, it just returns this:
$ bitcoin-cli sendrawtransaction 01000000018368ead3c8677725a71ba7d17dc181ef41ebafcddd833dc67842ed155e6620780000000049483045022100a62a6379db25aada0c0252c3bcac95038992327d851f85f455c85d12fc935b0a022020d01881135a35f173c7d58dc98cb09017e23bbbc182d8c993e10da6ebb8a68a01ffffffff0100301a1e010000001976a914c04b7b7d1d6de24c83a77dd229e1f4488b09ee9f88ac00000000
error: {"code":-25,"message":""}

@elichai
Copy link
Contributor

elichai commented Jun 15, 2014

Thanks for openning an issue, but if you'll add 'true' after the hex it will work, becuase 'sendrawtransaction' is accepting two arguements:

  1. "hexstring" (string, required) The hex string of the raw transaction)
  2. allowhighfees (boolean, optional, default=false) Allow high fees

@elichai
Copy link
Contributor

elichai commented Jun 15, 2014

drak, you right. i'm sorry.

@laanwj laanwj added the RPC label Jul 31, 2014
@macoymejia
Copy link

I already tried allowhighfees to "true", but still gives me -25 error code

bitcoind sendrawtransaction -hex- true
error: {"code":-25,"message":""}

@Michagogo
Copy link
Contributor Author

@macoymejia You seem to be missing, uh, the actual transaction...

@macoymejia
Copy link

oopsie... yeah there's <hex string> parameter (I thought comment will parse < and > as I type)

anyway... I found out that I'm sending invalid unspent item. no more -25 error :) thanks @Michagogo

@priiduneemre
Copy link

Still... in the long run, maybe a more descriptive error message should be returned when bouncing against the 'insane fee' check of sendrawtransaction(..)?

Took me quite a while to figure out what was wrong with my raw transaction and the generic error response wasn't really helping either:
{"result":null,"error":{"code":-25,"message":""},"id":"e7040c392ccb4adb92770dc168d97ae6"}

@sipa
Copy link
Member

sipa commented Mar 17, 2015

See #5913.

@paveljanik
Copy link
Contributor

Fixed now?

@laanwj
Copy link
Member

laanwj commented Oct 1, 2015

Yes.

@laanwj laanwj closed this as completed Oct 1, 2015
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants