rescanning uses incorrect date for old transactions

[dooglus]

I had a few conflicted transactions in my wallet, so I ran:

bitcoind -zapwallettxes=2

to delete them. After doing so, all my transactions from before January 2014 had a date of January 2014.

Upon checking the source code, I see this line in CWallet::AddToWallet() in wallet/wallet.cpp:

wtx.nTimeSmart = std::max(latestEntry, std::min(blocktime, latestNow));

blocktime is the time I want to see in my transactions, latestNow is much bigger, and so the min() returns the time I want, but latestEntry is January 2014, and so that's the time that is used for all my old transactions.

I'm not entirely clear how the Jan 2014 date is being found, since -zapwallettxes is meant to delete all the transactions and rescan to find them again, but it seems that

TxItems txOrdered = OrderedTxItems(acentries);

is finding a transaction from 2014, even after all transactions have been deleted.

I tried replacing the nTimeSmart = max(min()) code with this:

wtx.nTimeSmart = std::min(blocktime, latestNow);

then re-ran with the -zap flag, and now I see the correct dates next to all of my transactions.

[bitcartel]

Does this still need fixing?

bitcoin/src/wallet/wallet.cpp

Line 3700 in df91e11

nTimeSmart = std::max(latestEntry, std::min(blocktime, latestNow));

[ryanofsky]

It doesn't look like that line of code has changed since it was added in 2012 c3f95ef.

It sounds like dooglus had to remove the max with latestEntry part to avoid the problem.

[thejohnha]

I believe this is the issue causing older transactions to have incorrect dates when using the Export function out of the bitcoin-core client (GUI). It would be nice if the export function worked correctly... Many thanks 🙏🙏🙏

[kouloumos]

The logic mentioned here was initially extracted to ComputeTimeSmart with #9369 and the issue was later fixed with #20591. See #11703 (comment) for more details.

[maflcko]

Ok, closing for now. Can be reopened if the fix didn't work.