Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout for headers fetch #9068

Closed
sipa opened this issue Nov 2, 2016 · 2 comments
Closed

Timeout for headers fetch #9068

sipa opened this issue Nov 2, 2016 · 2 comments
Labels

Comments

@sipa
Copy link
Member

sipa commented Nov 2, 2016

When we request headers from a peer (something we do only for one peer when we're in IBD, to avoid duplicating it), there is no timeout. If the peer we're asking it from does not respond, we're stuck.

Fix this by adding a timeout, and integrating it in the block fetch timeout logic (because, when we already have outstanding block download requests, we can't header to appear quickly).

@laanwj laanwj added the P2P label Nov 2, 2016
@rebroad
Copy link
Contributor

rebroad commented Nov 3, 2016

I coded this back in 2013 but it never got merged... I can rebase it if it's now wanted.... It wasn't a fixed timeout but was calculated based on overall latency.

@fanquake
Copy link
Member

fanquake commented Oct 7, 2017

Closing after #10345.

@fanquake fanquake closed this as completed Oct 7, 2017
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants