New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis failure on rc3: "src/crypto/ctaes is not a subtree" #12388
Comments
The compressed size of the git objects for master at --depth 50 and --depth 99999 is 60 MiB and 80 MiB, respectively. On the rc3 tag it is 30 MiB, but still with a download rate of 19.80 MiB/s, this should have limited effect on the total run time. https://travis-ci.org/bitcoin/bitcoin/jobs/338906244#L351 |
Github-Pull: #12388 Tree-SHA512: 8dc7fd5619e60674021ef58f384ddaa2b0d49a88f8babab03697ab19819954f9521de0ede7398661be670ce6339bfea436b10ad916b72f194e18efdb3721c08d
I don't like that solution on the longer term, but it's ok for now on the 0.16 branch. |
Grr apparently we already have an |
We use a full clone now on all platforms (0f58d7f) due to
and to simplify the travis yaml Hope that is ok. |
Github-Pull: bitcoin#12388 Tree-SHA512: 8dc7fd5619e60674021ef58f384ddaa2b0d49a88f8babab03697ab19819954f9521de0ede7398661be670ce6339bfea436b10ad916b72f194e18efdb3721c08d
Travis on the 0.16 branch is failing on the subtree check.
The reason for this is that it makes a shallow clone, and the last change to that subtree is deeper than the oldest commit fetched.
The obvious solution would be to clone deeper, but that would be kicking the can down the road and make things slower. I'd say to be robust the check needs to generate a warning in this case but continue. If nothing changed to it in the last 50 commits, then the subtree can be assumed to be fine, otherwise we would have intervened by then.
Ping @MarcoFalke @sipa
The text was updated successfully, but these errors were encountered: