Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variable in SortForBlock #12693

Merged
merged 1 commit into from Mar 15, 2018
Merged

Remove unused variable in SortForBlock #12693

merged 1 commit into from Mar 15, 2018

Conversation

drewx2
Copy link

@drewx2 drewx2 commented Mar 15, 2018

Although txiter is passed to BlockAssembler::SortForBlock, it is never used. Other than BlockAssembler::addPackageTxs, no other method ever makes a call to SortForBlock, thus making this change harmless.

@practicalswift
Copy link
Contributor

practicalswift commented Mar 15, 2018 •
edited

Nice first-time contribution! Concept ACK!

@drewx2
Copy link
Author

drewx2 commented Mar 15, 2018

Thanks!

@donaloconnor
Copy link
Contributor

Concept ACK

@promag
Copy link
Member

promag commented Mar 15, 2018

Obvious ACK bb079a0. Have you checked if it was ever used and if so what PR changed that?

@sipa
Copy link
Member

sipa commented Mar 15, 2018

utACK bb079a0.

@sdaftuar Do you know if there was any reason to pass this variable down for a future purpose?

@sipa sipa requested a review from sdaftuar March 15, 2018 22:33
@sipa
Copy link
Member

sipa commented Mar 15, 2018

It was unused in c82a4e9, the commit that introduced the code.

@promag
Copy link
Member

promag commented Mar 15, 2018

Right, IMO should be removed now and added again only when needed.

@practicalswift
Copy link
Contributor

utACK bb079a0

sdaftuar
sdaftuar approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@sdaftuar sdaftuar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. I think this was just an oversight (perhaps leftover from my first implementation which didn't take advantage of ancestor-count-sorting to do the sort).

@sipa sipa merged commit bb079a0 into bitcoin:master Mar 15, 2018
sipa added a commit that referenced this pull request Mar 15, 2018
@sipa
Merge #12693: Remove unused variable in SortForBlock
df529dc 
bb079a0 Remove unused variable in SortForBlock (Drew Rasmussen)

Pull request description:

  Although txiter is passed to BlockAssembler::SortForBlock, it is never used. Other than BlockAssembler::addPackageTxs, no other method ever makes a call to SortForBlock, thus making this change harmless.

Tree-SHA512: c7df948c5f75f7371844200e0227a26476437f300148d29020e01041b382f5bda31d9c520c9c5425aee88ce8f4a52cd0e594985d69ed8a081b878cda2e4de8c5
Mengerian pushed a commit to Mengerian/bitcoin-abc that referenced this pull request Aug 6, 2019
@sipa
Merge #12693: Remove unused variable in SortForBlock
2d00337 
Summary:
bb079a0 Remove unused variable in SortForBlock (Drew Rasmussen)

Pull request description:

  Although txiter is passed to BlockAssembler::SortForBlock, it is never used. Other than BlockAssembler::addPackageTxs, no other method ever makes a call to SortForBlock, thus making this change harmless.

Tree-SHA512: c7df948c5f75f7371844200e0227a26476437f300148d29020e01041b382f5bda31d9c520c9c5425aee88ce8f4a52cd0e594985d69ed8a081b878cda2e4de8c5

Backport of Core PR12693
bitcoin/bitcoin#12693

Test Plan:
  make check

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3762
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 10, 2020
@sipa @PastaPastaPasta
Merge bitcoin#12693: Remove unused variable in SortForBlock
3ec86fd 
bb079a0 Remove unused variable in SortForBlock (Drew Rasmussen)

Pull request description:

  Although txiter is passed to BlockAssembler::SortForBlock, it is never used. Other than BlockAssembler::addPackageTxs, no other method ever makes a call to SortForBlock, thus making this change harmless.

Tree-SHA512: c7df948c5f75f7371844200e0227a26476437f300148d29020e01041b382f5bda31d9c520c9c5425aee88ce8f4a52cd0e594985d69ed8a081b878cda2e4de8c5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 13, 2020
@sipa @PastaPastaPasta
Merge bitcoin#12693: Remove unused variable in SortForBlock
0144b2b 
bb079a0 Remove unused variable in SortForBlock (Drew Rasmussen)

Pull request description:

  Although txiter is passed to BlockAssembler::SortForBlock, it is never used. Other than BlockAssembler::addPackageTxs, no other method ever makes a call to SortForBlock, thus making this change harmless.

Tree-SHA512: c7df948c5f75f7371844200e0227a26476437f300148d29020e01041b382f5bda31d9c520c9c5425aee88ce8f4a52cd0e594985d69ed8a081b878cda2e4de8c5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 13, 2020
@sipa @PastaPastaPasta
Merge bitcoin#12693: Remove unused variable in SortForBlock
427e31d 
bb079a0 Remove unused variable in SortForBlock (Drew Rasmussen)

Pull request description:

  Although txiter is passed to BlockAssembler::SortForBlock, it is never used. Other than BlockAssembler::addPackageTxs, no other method ever makes a call to SortForBlock, thus making this change harmless.

Tree-SHA512: c7df948c5f75f7371844200e0227a26476437f300148d29020e01041b382f5bda31d9c520c9c5425aee88ce8f4a52cd0e594985d69ed8a081b878cda2e4de8c5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 13, 2020
@sipa @PastaPastaPasta
Merge bitcoin#12693: Remove unused variable in SortForBlock
4fd7ef0 
bb079a0 Remove unused variable in SortForBlock (Drew Rasmussen)

Pull request description:

  Although txiter is passed to BlockAssembler::SortForBlock, it is never used. Other than BlockAssembler::addPackageTxs, no other method ever makes a call to SortForBlock, thus making this change harmless.

Tree-SHA512: c7df948c5f75f7371844200e0227a26476437f300148d29020e01041b382f5bda31d9c520c9c5425aee88ce8f4a52cd0e594985d69ed8a081b878cda2e4de8c5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 17, 2020
@sipa @PastaPastaPasta
Merge bitcoin#12693: Remove unused variable in SortForBlock
c94c99f 
bb079a0 Remove unused variable in SortForBlock (Drew Rasmussen)

Pull request description:

  Although txiter is passed to BlockAssembler::SortForBlock, it is never used. Other than BlockAssembler::addPackageTxs, no other method ever makes a call to SortForBlock, thus making this change harmless.

Tree-SHA512: c7df948c5f75f7371844200e0227a26476437f300148d29020e01041b382f5bda31d9c520c9c5425aee88ce8f4a52cd0e594985d69ed8a081b878cda2e4de8c5
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdaftuar sdaftuar sdaftuar approved these changes

Assignees
No one assigned
Labels
Mining Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@drewx2 @practicalswift @donaloconnor @promag @sipa @sdaftuar @fanquake