Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix help message typo optiona -> optional #14056

Merged
merged 1 commit into from Aug 27, 2018
Merged

Docs: Fix help message typo optiona -> optional #14056

merged 1 commit into from Aug 27, 2018

Conversation

Empact
Copy link
Member

@Empact Empact commented Aug 24, 2018

No description provided.

@Empact
Copy link
Member Author

Empact commented Aug 24, 2018

@practicalswift would #13954 catch this if rebased? If so I'll close in favor.

@fanquake fanquake added the Docs label Aug 24, 2018
@practicalswift
Copy link
Contributor

practicalswift commented Aug 25, 2018 •
edited

@Empact No, codespell wouldn’t have catched this typo specific typo I’m afraid :-)

codespell tries really hard not to generate false positives, so some typos will be missed.

FWIW, I’d guesstimate that >80 % of the typos introduced in the code base would be fixed before merge if automatic codespell checking is enabled as suggested in #13954.

codespell’s false positive probability is extraordinarly low so I think the maintenace cost would be near zero.

@laanwj
Copy link
Member

laanwj commented Aug 27, 2018

obvious utACK 7d0a8ad

fixing typos is good, but I still think they should not block travis as it is not a critical issue

@laanwj laanwj merged commit 7d0a8ad into bitcoin:master Aug 27, 2018
laanwj added a commit that referenced this pull request Aug 27, 2018
@laanwj
Merge #14056: Docs: Fix help message typo optiona -> optional
deed63f 
7d0a8ad Docs: Fix help message typo optiona -> optional (Ben Woosley)

Pull request description:

Tree-SHA512: 1812b45d912769f11280e3f72d7c8bd273f6d151797d5d32d21cd5a3bbe8725515406494291953be7a9afc02a2cef23bed1930ac3638f8118c0d8346ee8d6332
@maflcko maflcko added this to the 0.17.0 milestone Aug 27, 2018
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Aug 27, 2018
@Empact
Docs: Fix help message typo optiona -> optional
b5ec6d4 
Github-Pull: bitcoin#14056
Rebased-From: 7d0a8ad
@Bushstar Bushstar mentioned this pull request Sep 4, 2018
Merged
HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Sep 14, 2018
@Empact
Docs: Fix help message typo optiona -> optional
b500ea1 
Github-Pull: bitcoin#14056
Rebased-From: 7d0a8ad
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 16, 2020
@laanwj
Merge #14056: Docs: Fix help message typo optiona -> optional
9b51434 
Summary:
7d0a8ad3103200145ab2e73368c3b8345a66c15d Docs: Fix help message typo optiona -> optional (Ben Woosley)

Pull request description:

Tree-SHA512: 1812b45d912769f11280e3f72d7c8bd273f6d151797d5d32d21cd5a3bbe8725515406494291953be7a9afc02a2cef23bed1930ac3638f8118c0d8346ee8d6332

Backport of Core PR14056
bitcoin/bitcoin#14056

Test Plan:
  ninja check
  ./bitcoind
  ./bitcoin-cli help walletprocesspsbt
  ./bitcoin-cli help walletcreatefundedpsbt
  arc lint --everything
Confirm there are no instances of `optiona`.

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4962
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 18, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14056: Docs: Fix help message typo optiona -> optional
ba034c5 
7d0a8ad Docs: Fix help message typo optiona -> optional (Ben Woosley)

Pull request description:

Tree-SHA512: 1812b45d912769f11280e3f72d7c8bd273f6d151797d5d32d21cd5a3bbe8725515406494291953be7a9afc02a2cef23bed1930ac3638f8118c0d8346ee8d6332
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 18, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14056: Docs: Fix help message typo optiona -> optional
eb80c7d 
7d0a8ad Docs: Fix help message typo optiona -> optional (Ben Woosley)

Pull request description:

Tree-SHA512: 1812b45d912769f11280e3f72d7c8bd273f6d151797d5d32d21cd5a3bbe8725515406494291953be7a9afc02a2cef23bed1930ac3638f8118c0d8346ee8d6332
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 19, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14056: Docs: Fix help message typo optiona -> optional
638a460 
7d0a8ad Docs: Fix help message typo optiona -> optional (Ben Woosley)

Pull request description:

Tree-SHA512: 1812b45d912769f11280e3f72d7c8bd273f6d151797d5d32d21cd5a3bbe8725515406494291953be7a9afc02a2cef23bed1930ac3638f8118c0d8346ee8d6332
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 19, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14056: Docs: Fix help message typo optiona -> optional
bb5bd83 
7d0a8ad Docs: Fix help message typo optiona -> optional (Ben Woosley)

Pull request description:

Tree-SHA512: 1812b45d912769f11280e3f72d7c8bd273f6d151797d5d32d21cd5a3bbe8725515406494291953be7a9afc02a2cef23bed1930ac3638f8118c0d8346ee8d6332
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Empact @practicalswift @laanwj @fanquake @maflcko