Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issues from Coverity Static Analysis scan #17067

Closed
yashbhutwala opened this issue Oct 6, 2019 · 0 comments
Closed

Potential issues from Coverity Static Analysis scan #17067

yashbhutwala opened this issue Oct 6, 2019 · 0 comments
Labels

Comments

@yashbhutwala
Copy link

I recently got a chance to run the bitcoin source code through Synopsys's static analysis tool, Coverity. I thought it'd be good to report some of the potential issues detected upstream. I am not a C++ expert, nor do I have the depth of the source-code here, so some of these may-be non-issues. Regardless, I'm reporting some of the "high" severity issues marked through the tool. Hoping someone with a deeper understanding of the code-base can better assess them and patch as necessary :)

https://github.com/bitcoin/bitcoin/blob/master/src/crypto/hmac_sha256.cpp#L14
and
https://github.com/bitcoin/bitcoin/blob/master/src/crypto/hmac_sha512.cpp#L14

image

https://github.com/bitcoin/bitcoin/blob/master/src/leveldb/table/table_builder.cc#L56

image

https://github.com/bitcoin/bitcoin/blob/master/src/leveldb/db/c.cc#L160

image

https://github.com/bitcoin/bitcoin/blob/master/src/key_io.cpp#L166 and https://github.com/bitcoin/bitcoin/blob/master/src/key_io.cpp#L189

image

There is also other "medium" and "low" severity issues that may or may not be patch worthy. If someone is interested, please email me or ping me on this issue.

image

@fanquake fanquake closed this as completed Oct 8, 2019
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants