Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: settings.json issue #21974

Closed
AsalentsTech opened this issue May 17, 2021 · 8 comments
Closed

windows: settings.json issue #21974

AsalentsTech opened this issue May 17, 2021 · 8 comments
Labels

Comments

@AsalentsTech
Copy link

i am trying to install bitcoin core but cant it keeps saying unable to open or save the settings.json file or somehting like this i have uninstalled and reinstalled ten times same thing i even tried putting it on my exteernal hard drive and had same issue how do i fix so i cna download and install bitcoin core?
Capture

@jonatack
Copy link
Contributor

jonatack commented May 17, 2021

Hi @asalentsvpns666, which operating system and version are you using, which version of Bitcoin Core are you installing (from the downloaded binary or from source?), do you see a settings.json file in your data directory, and if yes, which permissions does that file have?

@fanquake fanquake changed the title i am trying to install bitcoin core but cant it keeps saying unable to open or save the settings.json file or somehting like this i have uninstalled and reinstalled ten times same thing i even tried putting it on my exteernal hard drive and had same issue how do i fix so i cna download and install bitcoin core? windows: settings.json issue May 17, 2021
@maflcko
Copy link
Member

maflcko commented May 17, 2021

Generally, it is not recommended to set the datadir to a top level directory like D:\.

Does anyone know if the uninstaller effectively clears the gui persisted settings like -resetguisettings does?

@Aumeeb
Copy link

Aumeeb commented Jun 26, 2021

@asalentsvpns666 Try to switch other disk, or using Virtual Machine?

@ryanofsky
Copy link
Contributor

I thought bitcoin-core/gui#379 might help address this issue, but it doesn't really. All it might do is make the "Settings file could not be written" error dialog a little more readable.

I guess the ideal thing to do in the gui when the datadir exists but isn't writable would be to prompt the user and give a choice of whether to exit or choose a new data directory. This would require shuffling the qt init code a bit since the settings file is written after Intro::showIfNeeded is called.

hebasto added a commit to bitcoin-core/gui that referenced this issue Aug 6, 2021
1ee6d0b gui: Prompt to reset settings when settings.json cannot be read (Russell Yanofsky)

Pull request description:

  Currently the GUI shows confusing error messages when `settings.json` can't be read or written on startup. This causes the unrecoverable read error described in bitcoin/bitcoin#21340 and write error described bitcoin/bitcoin#21974. Current error read message looks like:

  ![current](https://user-images.githubusercontent.com/7133040/124977362-638ffc80-dffe-11eb-9edd-89135a9bc602.png)

  This PR tries to clarify the error dialog, and adds an option to just clear the settings and reset them to default:

  ![new-read-error](https://user-images.githubusercontent.com/7133040/124977636-b669b400-dffe-11eb-8d35-02eda95f48c0.png)
  ![new-read-details](https://user-images.githubusercontent.com/7133040/124977644-bb2e6800-dffe-11eb-9209-11c1c3d7be40.png)

  Additionally the PR also shows a slightly better error message when there is an error trying to write the settings file. This error probably should occur less frequently, but it is easy to improve, and it should be good to make the write error consistent with the read error. The new write error dialog looks like:

  ![new-write-error](https://user-images.githubusercontent.com/7133040/124978016-3bed6400-dfff-11eb-9d79-9b2e9bbc4369.png)

  ![new-write-details](https://user-images.githubusercontent.com/7133040/124978025-3db72780-dfff-11eb-8df5-741f75a402d9.png)

ACKs for top commit:
  jarolrod:
    ACK 1ee6d0b
  Zero-1729:
    ACK 1ee6d0b
  hebasto:
    ACK 1ee6d0b, tested on Linux Mint 20.2 (Qt 5.12.8).

Tree-SHA512: fb57a0a0d032e3f8219fff49a4de69b4c962bf0b448544ccf9d8d4d45c5bd209e23653d4f13300b9e534b9c03de159498bef1658e95defe3ab6a8ecac57d592c
@hebasto
Copy link
Member

hebasto commented Aug 6, 2021

@asalentsvpns666

Could you try a build from the current master branch? If error persists, what is its description now?

@AsalentsTech
Copy link
Author

AsalentsTech commented Aug 6, 2021 via email

@hebasto
Copy link
Member

hebasto commented Aug 6, 2021

Could be closed?

@AsalentsTech
Copy link
Author

AsalentsTech commented Aug 6, 2021 via email

@hebasto hebasto closed this as completed Aug 6, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this issue Aug 6, 2021
…on cannot be read

1ee6d0b gui: Prompt to reset settings when settings.json cannot be read (Russell Yanofsky)

Pull request description:

  Currently the GUI shows confusing error messages when `settings.json` can't be read or written on startup. This causes the unrecoverable read error described in bitcoin#21340 and write error described bitcoin#21974. Current error read message looks like:

  ![current](https://user-images.githubusercontent.com/7133040/124977362-638ffc80-dffe-11eb-9edd-89135a9bc602.png)

  This PR tries to clarify the error dialog, and adds an option to just clear the settings and reset them to default:

  ![new-read-error](https://user-images.githubusercontent.com/7133040/124977636-b669b400-dffe-11eb-8d35-02eda95f48c0.png)
  ![new-read-details](https://user-images.githubusercontent.com/7133040/124977644-bb2e6800-dffe-11eb-9209-11c1c3d7be40.png)

  Additionally the PR also shows a slightly better error message when there is an error trying to write the settings file. This error probably should occur less frequently, but it is easy to improve, and it should be good to make the write error consistent with the read error. The new write error dialog looks like:

  ![new-write-error](https://user-images.githubusercontent.com/7133040/124978016-3bed6400-dfff-11eb-9d79-9b2e9bbc4369.png)

  ![new-write-details](https://user-images.githubusercontent.com/7133040/124978025-3db72780-dfff-11eb-8df5-741f75a402d9.png)

ACKs for top commit:
  jarolrod:
    ACK 1ee6d0b
  Zero-1729:
    ACK 1ee6d0b
  hebasto:
    ACK 1ee6d0b, tested on Linux Mint 20.2 (Qt 5.12.8).

Tree-SHA512: fb57a0a0d032e3f8219fff49a4de69b4c962bf0b448544ccf9d8d4d45c5bd209e23653d4f13300b9e534b9c03de159498bef1658e95defe3ab6a8ecac57d592c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants
@jonatack @maflcko @ryanofsky @Aumeeb @hebasto @AsalentsTech and others