-
Notifications
You must be signed in to change notification settings - Fork 35.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depends: qt build for HOST=aarch64-linux-android is broken for NDK 22+ #22074
Comments
cc @icota |
I think we should wait until r23 is released before taking any action. r21 is an LTS release and r22 is not |
Fair enough. Closing for now. |
From https://doc.qt.io/qt-5/android-getting-started.html#installing-the-prerequisites:
|
I think if we'd like to keep supporting Android builds for 23.0, someone should look into making Qt and the Android build work with r22. I can't imagine we are going to block migrating to I'd also assume that any of the Qt patching and build system changes that are going to be required will be very similar for r22 and r23 in any case (r23 support just being additional changes on top of r22 if any). |
Makes sense. @hebasto reopen? |
acaac6e ci: Bump Android NDK to r22 which supports std::filesystem (Hennadii Stepanov) cac7890 build: Add support for Android NDK r22+ (Hennadii Stepanov) Pull request description: This is required to support [`std::filesystem`](https://github.com/android/ndk/wiki/Changelog-r22#changes) on Android (see bitcoin#20744). Fixes bitcoin#22074. ACKs for top commit: icota: re-tACK bitcoin@acaac6e Tree-SHA512: ecbec374ee590c4cb30012210f1422d469e7e8b68989f9eb53d36b5feee150d31e6bd10e1fc4a2056fbf4f8f8513e435b446e5feaf21a3a4d09dfc561fb22e73
On master (456c8d6):
I seems related to this change:
The text was updated successfully, but these errors were encountered: