Testnet/mainnet cross-reading of settings

[achow101]

In the settings, the Testnet seems to be reading from and setting some options for mainnet and not testnet. I have noticed this with at least the strDataDir option.

Replication steps on Ubuntu 15.10

1. Tail ~/.config/Bitcoin-Qt.conf and ~/.config/Bitcoin-Qt-testnet.conf
2. Reset the testnet settings by going to Settings > Reset Options. Notice how the testnet conf file changes.
3. Now start Bitcoin core with -choosedatadir -testnet.

After the third step, you will see that the strDataDir setting is not added to the testnet conf but is added/changed in the normal conf file.

[jonasschnelli]

The settings overwritten by the GUI (QSettings) are stored/managed by QT. The filename is handled by Qt. I guess chaining the app name (using testnet switched the application name somewhere in init) could lead to a mixed settings read/write behavior.

[maflcko]

Are you starting with -choosedatadir or -choosedatadir -testnet?

[achow101]

-choosedatadir -testnet

On May 27, 2016 9:28:54 AM MarcoFalke notifications@github.com wrote:

Are you starting with -choosedatadir or -choosedatadir -testnet?

---

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#8106 (comment)

[beirut-boop]

Perhaps it would work as intended if we would use the NetworkStyle app name when locating QSettings. E.g.:

    /// 3. Application identification
    // must be set before OptionsModel is initialized or translations are loaded,
    // as it is used to locate QSettings
    QApplication::setOrganizationName(QAPP_ORG_NAME);
    QApplication::setOrganizationDomain(QAPP_ORG_DOMAIN);
-    QApplication::setApplicationName(QAPP_APP_NAME_DEFAULT);
+    QApplication::setApplicationName(networkStyle->getAppName());

But I am not confident this is all there is to it.

bitcoin/src/qt/bitcoin.cpp

Lines 496 to 501 in 8e1913a

	/// 3. Application identification
	// must be set before OptionsModel is initialized or translations are loaded,
	// as it is used to locate QSettings
	QApplication::setOrganizationName(QAPP_ORG_NAME);
	QApplication::setOrganizationDomain(QAPP_ORG_DOMAIN);
	QApplication::setApplicationName(QAPP_APP_NAME_DEFAULT);

bitcoin-core/gui#212

[achow101]

Moved to GUI repo: bitcoin-core/gui#759