-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v0.28.0 #26
Update to v0.28.0 #26
Conversation
932dba8
to
a1e156a
Compare
@@ -11,7 +11,7 @@ jobs: | |||
matrix: | |||
rust: | |||
- 1.65.0 # STABLE | |||
- 1.57.0 # MSRV | |||
- 1.59.0 # MSRV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the MSRV of a sub-dependency:
zip-rs/zip-old@a06b947
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to keep the 1.57.0 MSRV by adding to Cargo.toml
:
[dev-dependencies]
# zip versions after 0.6.3 don't work with our MSRV 1.57.0
zip = "=0.6.3"
# base64ct versions at 1.6.0 and higher have MSRV 1.60.0
base64ct = "<1.6.0"
See also: bitcoindevkit/bdk#877
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
a1e156a
to
bea8c17
Compare
10d6118
to
98a09a6
Compare
Not updating electrsd because of the MSRV
98a09a6
to
02bba37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 02bba37
No description provided.