fix(bdk): Check if we're using the correct internal key before signing #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
ACK c450499
Looks good! I confirmed test fails without the extra && x_only_pubkey == psbt_internal_key check. I just have one nit/suggestion on the test.
danielabrozzoni
force-pushed
the
issue/1142
branch
from
c450499
to
594726a
Compare
...internal key before signing Fixes bitcoindevkit#1142 We would previously sign with whatever x_only_pubkey we had in hand, without first checking if it was the right key or not. This effectively meant that adding multiple taproot PrivateKey signers would produce unbroadcastable transactions.
danielabrozzoni
force-pushed
the
issue/1142
branch
from
594726a
to
e553231
Compare
54 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1142
We would previously sign with whatever x_only_pubkey we had in hand, without first checking if it was the right key or not. This effectively meant that adding multiple taproot PrivateKey signers would produce unbroadcastable transactions.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: