Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bdk): Check if we're using the correct internal key before signing #1200

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix(bdk): Check if we're using the correct internal key before signing #1200

merged 1 commit into from
Nov 13, 2023

Commits on Nov 10, 2023

  1. fix(bdk): Check if we're using the correct... 

    ...internal key before signing

Fixes bitcoindevkit#1142

We would previously sign with whatever x_only_pubkey we had in hand,
without first checking if it was the right key or not. This effectively
meant that adding multiple taproot PrivateKey signers would produce
unbroadcastable transactions.
    @danielabrozzoni
    danielabrozzoni committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    e553231 View commit details
    Browse the repository at this point in the history