Make psbt mod public and add required docs #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2022
rajarshimaitra
approved these changes
Oct 20, 2022
notmandatory
added a commit
to bitcoindevkit/bdk-ffi
that referenced
this pull request
Nov 7, 2022
…ions ae1ea99 Add FeeRate struct and fee_amount() and fee_rate() functions on PartiallySignedTransaction (Steve Myers) 9a381f6 Rename PartiallySignedBitcoinTransaction to PartiallySignedTransaction (Steve Myers) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description Add FeeRate struct and fee_amount() and fee_rate() functions on PartiallySignedTransaction. ### Notes to the reviewers This PR is dependent on bitcoindevkit/bdk#782. ### Changelog notice - Breaking Changes - Renamed PartiallySignedBitcoinTransaction to PartiallySignedTransaction to be consistent with `rust-bitcoin` - APIs Added - Add FeeRate struct - Add fee_amount() and fee_rate() functions on PartiallySignedTransaction ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [x] I've added tests for the new feature * [x] I've added docs for the new feature ACKs for top commit: thunderbiscuit: Re-ACK [ae1ea99](ae1ea99). Tree-SHA512: 2c3f792e9ef092cd3ba233601122f4960c496d132caad54ef2f7f41d7113dd16600a863bb8fd78d2e5b978adebdb7ddd9529c21b3d46cd0b16e0db4eb90de01d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make psbt mod public and add required docs. The module needs to be public so
bdk-ffican expose the new PSBTfee_amount()andfee_rate()functions.Notes to the reviewers
I should have done this as part of #728.
Changelog notice
Make psbt module public to expose PsbtUtils trait to downstream projects.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: