Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change MSRV to 1.63.0 #69

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Dec 29, 2023

Since the main BDK crates are changing to MSRV 1.63.0 as is LDK this project also can be updated.

@notmandatory notmandatory self-assigned this Dec 29, 2023
@notmandatory notmandatory added the ci Continuous Integration issues label Dec 29, 2023
@notmandatory notmandatory added this to the Release 0.7.0 milestone Dec 29, 2023
@notmandatory notmandatory mentioned this pull request Dec 29, 2023
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2247e64

@notmandatory notmandatory merged commit e412a5f into bitcoindevkit:master Dec 29, 2023
15 checks passed
@notmandatory
Copy link
Member Author

Also rustc 1.63 is the version shipped with the current debian stable (bookworm): https://packages.debian.org/stable/rust/rustc

vladimirfomene added a commit that referenced this pull request Jan 2, 2024
c7c2a54 cargo: set rust-version to 1.63.0 (Steve Myers)

Pull request description:

  I forgot to do this is #69 .

ACKs for top commit:
  vladimirfomene:
    ACK c7c2a54

Tree-SHA512: 87afaf5c51e06f0110d8d92da069830c2278920d56636a5413f69b5f2bce88cda8791ea38843bffe611498b8c59710d9d3f0266f9aa3d150f39a7e75382309f9
@oleonardolima oleonardolima mentioned this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants