Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade bitcoin #60

Closed
wants to merge 1 commit into from
Closed

Upgrade bitcoin #60

wants to merge 1 commit into from

Conversation

tcharding
Copy link
Contributor

@tcharding tcharding commented Oct 16, 2023 •
edited
Loading

Upgrade dependencies to use the latest rust-bitcoin v0.31.

While we are at it, bump the crate version ready for release.

@tcharding
Copy link
Contributor Author

Needs rust-electrum-client release as well as electrsd.

@notmandatory notmandatory mentioned this pull request Dec 13, 2023
Closed
@notmandatory
Copy link
Member

Needs rust-electrum-client release as well as electrsd.

new electrum-client 0.19 is ready to go: https://crates.io/crates/electrum-client/0.19.0

@tcharding
Copy link
Contributor Author

tcharding commented Dec 21, 2023 •
edited
Loading

Needs electrsd release still: RCasatta/electrsd#74

@tcharding tcharding marked this pull request as ready for review December 23, 2023 02:04
@tcharding
Copy link
Contributor Author

tcharding commented Dec 23, 2023 •
edited
Loading

I think the pinning problems are unrelated to this PR, leaving that for someone else.

cargo test --all-features --all-targets runs cleanly locally on this branch.

@notmandatory notmandatory added this to the Release 0.7.0 milestone Dec 29, 2023
@notmandatory
Copy link
Member

I made #69 to bump our MSRV to 1.63 and fix the CI issues.

@tcharding tcharding force-pushed the 10-16-upgrade-bitcoin branch 2 times, most recently from fcdec65 to 80218a4 Compare January 5, 2024 22:02
@tcharding
Copy link
Contributor Author

The test_get_height fail needs investigating, will come back to this.

@tcharding
Copy link
Contributor Author

tcharding commented Jan 7, 2024 •
edited
Loading

The test_get_height test passes locally for me and the RawFd error seems unrelated to this PR.

@tcharding
Upgrade bitcoin
e53ba34 
Upgrade dependencies to use the latest `rust-bitcoin v0.31`.

While we are at it, bump the crate version ready for release.
@tcharding
Copy link
Contributor Author

No changes, just kicking CI.

@getong getong mentioned this pull request Jan 27, 2024
Closed
@getong
Copy link

getong commented Jan 27, 2024

It looks good. Still working for it?

@getong getong mentioned this pull request Jan 27, 2024
Closed
@getong
Copy link

getong commented Jan 27, 2024

I open #74 , which fix the ci error.
The ci result can be seen here
getong#1

@getong getong mentioned this pull request Jan 27, 2024
Closed
5 tasks
@tcharding
Copy link
Contributor Author

I'm happy for you to take over, closing in favour of #74. Thanks

@tcharding tcharding closed this Jan 29, 2024
This was referenced Feb 7, 2024
Closed
Merged
@notmandatory notmandatory removed this from the Release 0.7.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tcharding tcharding

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcharding @notmandatory @getong