Store out-of-order blocks from local devices #12
Conversation
|
Fixed a number of issues, and moved main out-of-order-blocks code to another file. |
| return ooob_db; | ||
| } | ||
|
|
||
| bool StoreOoOBlock(const CChainParams& chainparams, const std::shared_ptr<const CBlock> pblock) EXCLUSIVE_LOCKS_REQUIRED(cs_main) |
There was a problem hiding this comment.
It'd be nice to put a CheckBlock in here first.
There was a problem hiding this comment.
Put it at the caller, since that's where it's deciding whether or not to do the storing.
| @@ -3431,7 +3431,7 @@ bool CChainState::AcceptBlock(const std::shared_ptr<const CBlock>& pblock, CVali | |||
| return true; | |||
| } | |||
|
|
|||
| bool ProcessNewBlock(const CChainParams& chainparams, const std::shared_ptr<const CBlock> pblock, bool fForceProcessing, bool *fNewBlock) | |||
| bool ProcessNewBlock(const CChainParams& chainparams, const std::shared_ptr<const CBlock> pblock, bool fForceProcessing, bool *fNewBlock, const CDiskBlockPos *diskpos, const bool do_ooob) | |||
There was a problem hiding this comment.
Instead of refactoring PNB to pass the diskpos through, I think it would be more maintainable if you just call AcceptBlock from outoforder.cpp.
There was a problem hiding this comment.
AcceptBlock is not exposed outside of validation.cpp, and calling it directly would entail rewriting the rest of ProcessNewBlock too - which will make rebasing more complex, as any changes there would need to be ported over.
|
I tested this by turning off my satellite connection to skip blocks 560822 through and including 560825. I kept bitcoind running. I then turned blocksat-rx back on and Luke's code kept blocks 560826- to the tip cached while I waited for the satellite to broadcast my missing blocks. Once I got block 560825 to close the gap in my chain, my node caught right up to the tip in short order. |
|
I've been running this code since the day Luke wrote it. No issues to report. Many successful recoveries from a temporarily unavailable connection (like every Friday when pool guy comes and parks his truck in front of my satellite dish). |
|
I'd like to bump this and get it merged so it will be easier for Blockstream Satellite users to build. Without this patch, those users' nodes may become stuck. |
No description provided.