Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing coverage #47

Closed
kyledrake opened this issue Mar 2, 2014 · 4 comments
Closed

Improve testing coverage #47

kyledrake opened this issue Mar 2, 2014 · 4 comments

Comments

@kyledrake
Copy link
Contributor

Here's the current state:

Current coverage testing

Istanbul is installed, so you can run this command to get the report on your local machine in the coverage dir as an HTML page:

istanbul cover ./node_modules/.bin/_mocha -- --reporter list test/*.js
@weilu
Copy link
Contributor

weilu commented Mar 28, 2014

@kyledrake Do you have a test coverage threshold in mind, at which point we can close this?

@dcousens
Copy link
Contributor

I can't imagine why you wouldn't 100% test coverage.
As mentioned in #96 , the high number of code paths that can be taken at the moment is likely due to the number of overloaded constructors that exist.

I think we should streamline the API's as soon as possible.
It would make testing simpler too.

Current coverage report
http://i.imgur.com/GLXVsyI.png

@ralphtheninja
Copy link
Contributor

It would be nice if we could pick one of the files (e.g. the most important one, if there is such a file) and agree on how to streamline the API of that file and use it as a guidance for the other files.

@kyledrake
Copy link
Contributor Author

We have much better testing now, I am closing this!

louisinger added a commit to louisinger/liquidjs-lib that referenced this issue Apr 1, 2022
@louisinger
Allow to set finalScriptWitness in Psbt class (bitcoinjs#47)
493fe30 
* temp: allow to set finalScriptWitness in Psbt

* export witnessStackToScriptWitness function

* lint

* add Psbt.TX getter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kyledrake @ralphtheninja @weilu @dcousens