cli: more robust bitcoin-cli -getinfo command parsing

per Luke Dashjr review feedback in PR 18594 Github-Pull: bitcoin#19089 Rebased-From: d83ae3e
bitcoinknots · Jun 13, 2020 · 2be8ee8 · 2be8ee8
1 parent 46aaa05
commit 2be8ee8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/bitcoin-cli.cpp b/src/bitcoin-cli.cpp
@@ -530,7 +530,7 @@ static int CommandLineRPC(int argc, char *argv[])
         }
         std::unique_ptr<BaseRequestHandler> rh;
         std::string method;
-        if (gArgs.IsArgSet("-getinfo")) {
+        if (gArgs.GetBoolArg("-getinfo", false)) {
             rh.reset(new GetinfoRequestHandler());
         } else {
             rh.reset(new DefaultRequestHandler());
@@ -564,7 +564,7 @@ static int CommandLineRPC(int argc, char *argv[])
                 }
             }
         } else {
-            if (gArgs.IsArgSet("-getinfo") && !gArgs.IsArgSet("-rpcwallet")) {
+            if (gArgs.GetBoolArg("-getinfo", false) && !gArgs.IsArgSet("-rpcwallet")) {
                 GetWalletBalances(result); // fetch multiwallet balances and append to result
             }
             // Result