Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional poplinks for decks #95

Merged
merged 5 commits into from
Aug 12, 2021
Merged

Add additional poplinks for decks #95

merged 5 commits into from
Aug 12, 2021

Conversation

jonasdn
Copy link
Contributor

@jonasdn jonasdn commented Aug 11, 2021

  • Add poplink for Active Marker Deck
  • Add poplink for Motion capture marker deck

@knmcguire
Copy link
Member

Thanks! I'll be adding some additional commits for consistency!

@knmcguire
Copy link
Member

Just pushed some commits

  • There ware some link issues in the markdown of the pop-links, so some URL referrals failed
  • I just added and removed pop links in places so that it was more consistency on where the others were placed.
  • The blogpost I've removed about the active marker deck, as we don't do this in other poplinks, however might be an idea for Move detailed product infofrom store to web #93 to add this to the product page?

if this looks good to you, then let's merge and deploy the web tomorrow

Copy link
Contributor Author

@jonasdn jonasdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@knmcguire
Copy link
Member

awesome ! let's merge it

@knmcguire knmcguire merged commit 0a501c0 into master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants