Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Flapper platform #1123

Closed
wants to merge 5 commits into from

Conversation

matejkarasek
Copy link
Contributor

This PR adds a "flapper" platform, together with default settings and gain values.

@knmcguire
Copy link
Member

Could you resolve the build issue that the CI caught? You can check out the log in details

@krichardsson
Copy link
Contributor

Does this PR depend on 1122? Does it have to be merged first?

@matejkarasek
Copy link
Contributor Author

matejkarasek commented Oct 3, 2022

Does this PR depend on 1122? Does it have to be merged first?

I have included the original commits from #1122 (and #1121) also in this PR, so it is already merged.

I am working on fixing the remaining issues.
Next to the feed-forward gains mentioned in the discussion of #1122 but left out eventually, I have see redefinition issues with when multiple power distributions are used, will see, what can be done about that

@matejkarasek matejkarasek marked this pull request as draft October 4, 2022 10:27
@krichardsson
Copy link
Contributor

@matejkarasek maybe you should consider creating a new PR for adding the flapper?
I have merged your other two PRs and I think it would be cleaner to make a new branch from master for this PR. Currently this PR contains all the changes from the other two and it is hard to understand what is flapper related.

I have also merged a PR that updates the build scripts a bit and all you have to do build flapper in CI is to add i to the build_targets.json file

@matejkarasek
Copy link
Contributor Author

Yes, will do that soon, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants